Skip to content

[None][test] Update bug ID for test_all_optimizations_combined waiver - #14402

Merged
mzweilz merged 1 commit into
NVIDIA:mainfrom
mzweilz:dev-mengzew-fix-bug-id-in-waive-list
May 21, 2026
Merged

[None][test] Update bug ID for test_all_optimizations_combined waiver#14402
mzweilz merged 1 commit into
NVIDIA:mainfrom
mzweilz:dev-mengzew-fix-bug-id-in-waive-list

Conversation

@mzweilz

@mzweilz mzweilz commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated test skip configuration to reference updated internal tracking information.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
@mzweilz

mzweilz commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Update bug ID in the waive list only, skip testing"

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR updates a single test waiver entry in the integration test waivers list, changing the referenced NVIDIA bug ID from 6175060 to 6199854 for the TestFluxCombinedOptimizations::test_all_optimizations_combined test case.

Changes

Test Waiver Update

Layer / File(s) Summary
Waiver bug ID update
tests/integration/test_lists/waives.txt
The SKIP waiver entry for TestFluxCombinedOptimizations::test_all_optimizations_combined is updated to reference NV bug 6199854 instead of 6175060.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14093: Both PRs modify tests/integration/test_lists/waives.txt to update NV bug ID references for test waivers.
  • NVIDIA/TensorRT-LLM#14131: Directly related; the main PR updates the same SKIP waiver entry for TestFluxCombinedOptimizations::test_all_optimizations_combined with the identical bug ID change.
  • NVIDIA/TensorRT-LLM#11236: Both PRs modify tests/integration/test_lists/waives.txt by altering SKIP entries for flaky tests.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely composed of the template with no substantive content filled in for the key sections (Description, Test Coverage). Fill in the Description section explaining why the bug ID was updated from 6175060 to 6199854, and confirm which tests validate this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly specifies the change: updating a bug ID for a test waiver entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mzweilz
mzweilz enabled auto-merge (squash) May 21, 2026 09:21
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49670 [ skip ] triggered by Bot. Commit: e8bfc62 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49670 [ skip ] completed with state SUCCESS. Commit: e8bfc62
Skipping testing for commit e8bfc62

Link to invocation

@mzweilz
mzweilz merged commit 97f2dda into NVIDIA:main May 21, 2026
13 of 15 checks passed
xxi-nv pushed a commit to xxi-nv/TensorRT-LLM that referenced this pull request May 22, 2026
…NVIDIA#14402)

Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
KleinBlueC pushed a commit to KleinBlueC/TensorRT-LLM that referenced this pull request May 26, 2026
…NVIDIA#14402)

Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
…NVIDIA#14402)

Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants