[None][fix] Cherry-pick PR #14276: Handle unset attention_dp_relax in ADP routers - #14431
Merged
lancelly merged 1 commit intoMay 22, 2026
Merged
Conversation
) Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com> (cherry picked from commit 3de344d) Signed-off-by: Lance Liao <108499334+lancelly@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #49805 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #49805 [ run ] completed with state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of upstream main PR #14276 (3de344d384) onto the
feat/deepseek_v4development branch.Why:
feat/deepseek_v4does not yet have PR #14276 (merged onmain2026-05-19). Without it, thefeat/deepseek_v4line crashes at every Phase-transition point where the request batch contains multipleSchedulingParamsobjects withattention_dp_relax = None:This was reproduced on an agg DSV4-Pro RWLT validation run (2 nodes × GB300, TP8/TEP8/MTP3) at the Phase 0 → Phase 1 transition (concurrency 1 → 4) — all 8 ranks crashed simultaneously on both
DefaultADPRouter.route_requests(line 232) andKVCacheAwareADPRouter.route_requests(line 517), since both routers share the sameget_relax_valuehelper that dereferencesscheduling_params.attention_dp_relaxwhich can beNone.The upstream fix in PR #14276 changes the root cause — the default value of
SchedulingParams.attention_dp_relax:so the router's
sorted(...)no longer seesNonekeys. Treating unset = "relaxed" (True) matches the semantics: an unset request has no specific rank preference and can be routed anywhere.