Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 39661 - #14520

Closed
ZhanruiSunCh wants to merge 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260525-065205
Closed

[None][infra] Waive 1 failed cases for main in pre-merge 39661#14520
ZhanruiSunCh wants to merge 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260525-065205

Conversation

@ZhanruiSunCh

@ZhanruiSunCh ZhanruiSunCh commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @chienchunhung)
Target branch: main
Bug(s): 6216105

Waive entries added

full:DGX_H100/disaggregated/test_disaggregated.py::test_disaggregated_ctxpp2_genpp2[TinyLlama-1.1B-Chat-v1.0] SKIP (https://nvbugs/6216105)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

  • Tests
    • Updated test skip configuration for improved test management.

Review Change Stack

Bug(s): 6216105
Requested by: @chienchunhung

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR adds a single test waiver entry to mark the DGX_H100 disaggregated context-prefill and generation-prefill test case for TinyLlama as skipped, with a reference to the associated nvbugs issue.

Changes

Test waiver configuration

Layer / File(s) Summary
Add DGX_H100 disaggregated test waiver
tests/integration/test_lists/waives.txt
A new SKIP waiver entry is added for test_disaggregated_ctxpp2_genpp2[TinyLlama-1.1B-Chat-v1.0] on the DGX_H100 platform, marking it as skipped with a corresponding nvbugs reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14450: Both PRs add SKIP waivers to tests/integration/test_lists/waives.txt for failing integration test cases using the same waiver mechanism.
  • NVIDIA/TensorRT-LLM#14350: Both PRs add new SKIP entries to the same waives file for failing test cases.
  • NVIDIA/TensorRT-LLM#14514: Both PRs modify tests/integration/test_lists/waives.txt by adding SKIP/waiver entries for specific failing test cases.

Suggested reviewers

  • yiqingy0
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete and does not follow the required template structure, missing required sections like Description, Test Coverage, and PR Checklist. Add the missing template sections: Description explaining the waiver, Test Coverage section, and complete the PR Checklist items where applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies this as an infrastructure change to waive failed test cases, with specific reference to the pre-merge run number.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)

273-273: Waiver entry format looks correct; QA list updates are not required for this PR.

This is a waiver-only change in tests/integration/test_lists/waives.txt (no new/modified integration test definitions), so no update is needed in tests/integration/test_lists/qa/* or test-db perf list files for this PR.

As per coding guidelines, for waiver/list-only updates you should explicitly confirm QA list updates are unnecessary. Based on learnings, using the short nvbugs URL format in this file is preferred and is followed here.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` at line 273, Summary: waiver-only
change is fine but you must explicitly state QA list updates are not required;
update the PR/commit message or add a short confirmation in the change
describing that this is a waiver-only edit and no changes to
tests/integration/test_lists/qa/* or perf lists are needed. Specifically
reference the waiver entry
"DGX_H100/disaggregated/test_disaggregated.py::test_disaggregated_ctxpp2_genpp2[TinyLlama-1.1B-Chat-v1.0]
SKIP (https://nvbugs/6216105)" and note the preferred short nvbugs URL format
was used.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 273: Summary: waiver-only change is fine but you must explicitly state QA
list updates are not required; update the PR/commit message or add a short
confirmation in the change describing that this is a waiver-only edit and no
changes to tests/integration/test_lists/qa/* or perf lists are needed.
Specifically reference the waiver entry
"DGX_H100/disaggregated/test_disaggregated.py::test_disaggregated_ctxpp2_genpp2[TinyLlama-1.1B-Chat-v1.0]
SKIP (https://nvbugs/6216105)" and note the preferred short nvbugs URL format
was used.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5c348d73-7061-42aa-8c57-e21032782277

📥 Commits

Reviewing files that changed from the base of the PR and between e6d4f9f and ccbe409.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants