Skip to content

[https://nvbugs/6215684][fix] Fix invalid links in deployment guide - #14522

Merged
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/fix_nvbug_6215684
May 25, 2026
Merged

[https://nvbugs/6215684][fix] Fix invalid links in deployment guide#14522
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/fix_nvbug_6215684

Conversation

@nv-guomingz

@nv-guomingz nv-guomingz commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Documentation

    • Updated deployment guide links to point to non-OS-specific TensorRT-LLM build-from-source documentation across multiple model guides (DeepSeek R1, GLM-5, GPT-OSS, LLaMA 3.3, LLaMA 4 Scout, Nemotron 3 Super).
  • Tests

    • Enabled URL validity testing for documentation links.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
@nv-guomingz
nv-guomingz requested a review from a team as a code owner May 25, 2026 07:25
@nv-guomingz

Copy link
Copy Markdown
Collaborator Author

/bot run

@nv-guomingz
nv-guomingz enabled auto-merge (squash) May 25, 2026 07:25
@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5a317c85-817b-4046-9263-a5574cb85817

📥 Commits

Reviewing files that changed from the base of the PR and between 8c8765d and b5d47a2.

📒 Files selected for processing (7)
  • docs/source/deployment-guide/deployment-guide-for-deepseek-r1-on-trtllm.md
  • docs/source/deployment-guide/deployment-guide-for-glm-5-on-trtllm.md
  • docs/source/deployment-guide/deployment-guide-for-gpt-oss-on-trtllm.md
  • docs/source/deployment-guide/deployment-guide-for-llama3.3-70b-on-trtllm.md
  • docs/source/deployment-guide/deployment-guide-for-llama4-scout-on-trtllm.md
  • docs/source/deployment-guide/deployment-guide-for-nemotron-3-super-on-trtllm.md
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR updates TensorRT-LLM documentation links across six deployment guides from Linux-specific URLs to generic build-from-source documentation URLs. The test waiver for URL validity is removed, enabling the test to validate the updated links.

Changes

Documentation Link Updates and Test Enablement

Layer / File(s) Summary
Deployment guide build-from-source link updates
docs/source/deployment-guide/deployment-guide-for-deepseek-r1-on-trtllm.md, deployment-guide-for-glm-5-on-trtllm.md, deployment-guide-for-gpt-oss-on-trtllm.md, deployment-guide-for-llama3.3-70b-on-trtllm.md, deployment-guide-for-llama4-scout-on-trtllm.md, deployment-guide-for-nemotron-3-super-on-trtllm.md
Six deployment guides are updated with consistent link changes: each replaces the Linux-specific build-from-source documentation URL with a generic build-from-source documentation URL, directing users to the non-OS-specific TensorRT-LLM build documentation for the main branch.
Enable URL validity test
tests/integration/test_lists/waives.txt
The SKIP waiver for test_doc.py::test_url_validity is removed from the test waivers list, enabling the test to run and validate documentation links against the updated URLs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14514: Both PRs modify tests/integration/test_lists/waives.txt by adding/removing the waiver for test_doc.py::test_url_validity, directly conflicting on the same test entry.
  • NVIDIA/TensorRT-LLM#14387: Both PRs modify tests/integration/test_lists/waives.txt by removing SKIP waivers for integration tests to enable validation.
  • NVIDIA/TensorRT-LLM#14450: Both PRs modify tests/integration/test_lists/waives.txt by changing which integration tests are waived.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete; it contains only the template with placeholder comments and lacks actual implementation details, rationale, and test coverage information. Fill in the Description section explaining which links were invalid and why they were updated. Add Test Coverage section listing relevant tests (e.g., test_url_validity). Complete or remove empty sections and the placeholder '@coderabbitai summary' tag.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed Title is specific and directly related to the main change: fixing invalid links in deployment guide documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50170 [ run ] triggered by Bot. Commit: b5d47a2 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50170 [ run ] completed with state SUCCESS. Commit: b5d47a2
/LLM/main/L0_MergeRequest_PR pipeline #39714 completed with status: 'SUCCESS'

CI Report

Link to invocation

@nv-guomingz
nv-guomingz merged commit 01c9a34 into NVIDIA:main May 25, 2026
14 of 15 checks passed
KleinBlueC pushed a commit to KleinBlueC/TensorRT-LLM that referenced this pull request May 26, 2026
…VIDIA#14522)

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
…VIDIA#14522)

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants