[None][infra] Waive 2 failed cases for main in post-merge 2734 - #14526
Conversation
Bug(s): 6215684, 6215688 Requested by: @mzweilz Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
|
/bot skip --comment "Post merge waive PR created via CI report, skip testing." |
📝 WalkthroughWalkthroughThis PR adds two new test waiver entries to the integration test skip list: ChangesTest Waivers
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
354-354: QA test list updates are not required for these waivers.Both waived tests appear to be narrow-scope tests (documentation URL validation and visual generation example) rather than core integration tests under
tests/integration/defs/that would require entries intests/integration/test_lists/qa/. These waivers appropriately skip already-defined tests without impacting QA scheduled test coverage.Based on learnings: In tests/integration/test_lists/waives.txt, both entries correctly use the short nvbug URL format (https://nvbugs/XXXX) for consistency.
Also applies to: 370-370
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 354, Update the waivers file so no QA test list entries are added: keep the skip entries as short nvbug URLs and ensure both waived tests use that short format; specifically verify and, if needed, change the entries referencing test_doc.py::test_url_validity (line shown) and the other waived visual-generation example (also noted) inside tests/integration/test_lists/waives.txt so they use the https://nvbugs/XXXX short URL style and do not create entries under tests/integration/test_lists/qa/.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 370: Update the pytest node-id in waives.txt so the waiver matches the
actual test; replace the standalone "test_wan_t2v_example SKIP
(https://nvbugs/6215688)" entry with the fully-qualified node id
"examples/test_visual_gen.py::test_wan_t2v_example SKIP
(https://nvbugs/6215688)" so it matches the test referenced in test-db and will
be skipped correctly.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 354: Update the waivers file so no QA test list entries are added: keep
the skip entries as short nvbug URLs and ensure both waived tests use that short
format; specifically verify and, if needed, change the entries referencing
test_doc.py::test_url_validity (line shown) and the other waived
visual-generation example (also noted) inside
tests/integration/test_lists/waives.txt so they use the https://nvbugs/XXXX
short URL style and do not create entries under
tests/integration/test_lists/qa/.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1ad41ab4-358d-4cdd-930b-86d133c1bda3
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #50193 [ skip ] triggered by Bot. Commit: |
|
/bot run --stage-list "A10-Build_Docs" |
|
PR_Github #50193 [ skip ] completed with state |
|
PR_Github #50194 [ run ] triggered by Bot. Commit: |
|
PR_Github #50194 [ run ] completed with state
|
|
/bot run --stage-list "A10-Build_Docs" |
|
PR_Github #50203 [ run ] triggered by Bot. Commit: |
|
PR_Github #50203 [ run ] completed with state
|
Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
|
/bot run --stage-list "A10-Build_Docs" |
Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
|
/bot run --stage-list "A10-Build_Docs" |
|
PR_Github #50256 [ run ] triggered by Bot. Commit: |
|
PR_Github #50258 [ run ] triggered by Bot. Commit: |
|
PR_Github #50256 [ run ] completed with state |
|
/bot skip --comment "Check Test List passed, skip other testing." |
|
PR_Github #50258 [ run ] completed with state |
|
PR_Github #50265 [ skip ] triggered by Bot. Commit: |
|
PR_Github #50265 [ skip ] completed with state |
…A#14526) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
3 participants
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @mzweilz)
Target branch:
mainBug(s): 6215684, 6215688
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit