[https://nvbugs/5979673][fix] Pin nixl-cu13==0.9.0 instead of nixl meta-package - #14567
[https://nvbugs/5979673][fix] Pin nixl-cu13==0.9.0 instead of nixl meta-package#14567Shixiaowei02 wants to merge 2 commits into
Conversation
4e43b56 to
c510e75
Compare
|
/bot run --disable-fail-fast |
📝 WalkthroughWalkthroughReplaces the development dependency ChangesCUDA 13 Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #50341 [ run ] triggered by Bot. Commit: |
|
PR_Github #50341 [ run ] completed with state
|
c510e75 to
5cacbca
Compare
|
/bot run --stage-list "A10-PyTorch-1" --disable-fail-fast |
|
PR_Github #50417 [ run ] triggered by Bot. Commit: |
5cacbca to
4ab94b7
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #50438 [ run ] triggered by Bot. Commit: |
|
PR_Github #50438 [ run ] completed with state |
4ab94b7 to
120a83f
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #50461 [ run ] triggered by Bot. Commit: |
|
PR_Github #50461 [ run ] completed with state
|
|
PR_Github #50976 [ run ] triggered by Bot. Commit: |
|
PR_Github #50976 [ run ] completed with state
|
c842a11 to
b768245
Compare
|
/bot run --disable-fail-fast |
The trtllm dev environment used to install the meta `nixl` package, which provides a top-level `nixl/__init__.py` shim that redirects to `nixl_cu13` / `nixl_cu12`. After NVIDIA#14436 switched the dependency to `nixl-cu13` directly, the meta shim is no longer present, so `from nixl import nixl_agent, ...` in `tensorrt_llm/_torch/disaggregation/nixl/_agent_py.py` raises `ModuleNotFoundError: No module named 'nixl'` at import time, which in turn breaks `test_agent_multi_backends::test_run_with_different_env[1]` during collection of the spawned subprocess pytest. Resolve the symbols from `nixl_cu13` (or `nixl_cu12`) first and fall back to the meta-package only when neither CUDA-specific package is installed. Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
This case (TRTLLM_USE_PY_NIXL_KVCACHE=1) was waived under nvbugs/5979673 because the meta `nixl` package pulled the latest `nixl-cu12` wheel, whose `_bindings.so` referenced symbols absent from the source-built 0.9.0 `libnixl.so`. With `nixl-cu13==0.9.0` directly pinned in requirements-dev.txt, the bindings and the libnixl in the container are ABI-consistent again, so the test is expected to pass. Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
|
PR_Github #51355 [ run ] triggered by Bot. Commit: |
b768245 to
7b73fda
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #51356 [ run ] triggered by Bot. Commit: |
|
PR_Github #51355 [ run ] completed with state |
|
PR_Github #51356 [ run ] completed with state
|
7b73fda to
dcf3fde
Compare
|
/bot run --disable-fail-fast |
1 similar comment
|
/bot run --disable-fail-fast |
dcf3fde to
af5beae
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #51485 [ run ] triggered by Bot. Commit: |
|
PR_Github #51485 [ run ] completed with state |
|
/bot skip --comment "CI had already passed before handling the waive file conflicts." |
Pull request was converted to draft
|
PR_Github #51720 [ skip ] triggered by Bot. Commit: |
|
PR_Github #51720 [ skip ] completed with state |
b5da4cf to
7b73fda
Compare
|
Moved to #14939 |
The
nixlPyPI package became a meta-package whose only dependency isnixl-cu12with no version constraint, sonixl==0.9.0resolves tonixl-cu12==<latest>(currently 1.1.0). The 1.1.0 bindings reference a new 3-arg overload ofnixlAgent::prepXferDlist(withnixlAgentOptionalArgs) that does not exist in the source-built 0.9.0libnixl.soshipped in the container, causing the test_agent unit test to fail at import time with an undefined-symbol error.Pin
nixl-cu13==0.9.0directly so:_bindings.soonly depends on the 4-argprepXferDlist, which matches both the wheel's bundled libnixl and the source-built 0.9.0 libnixl;Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.