[None][fix] Exclude post-merge stages from CBTS force-keep filters - #14594
Conversation
CBTS force-keep patterns (PerfSanity, PackageSanityCheck) matched post-merge stages by name, causing them to run in pre-merge CI pipelines. Add a top-level guard so Post-Merge stages are only included when explicitly listed in affected_stages. Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR modifies the CBTS stage-filtering logic in the Jenkins test launcher to add a condition for Post-Merge stages. When a stage key matches ChangesCBTS Post-Merge Stage Filtering
🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
|
PR_Github #50373 [ run ] triggered by Bot. Commit: |
|
PR_Github #50373 [ run ] completed with state
|
crazydemo
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix.
|
/bot run |
|
PR_Github #50436 [ run ] triggered by Bot. Commit: |
|
PR_Github #50436 [ run ] completed with state
|
|
/bot run |
|
PR_Github #50568 [ run ] triggered by Bot. Commit: |
|
PR_Github #50568 [ run ] completed with state
|
|
/bot run |
|
PR_Github #50610 [ run ] triggered by Bot. Commit: |
|
PR_Github #50610 [ run ] completed with state |
Summary by CodeRabbit
Description
CBTS force-keep patterns (PerfSanity, PackageSanityCheck) matched post-merge stages by name, causing them to run in pre-merge CI pipelines. Add a top-level guard so Post-Merge stages are only included when explicitly listed in affected_stages.
Follow up to #13382
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.