Skip to content

[None][fix] Exclude post-merge stages from CBTS force-keep filters - #14594

Merged
tburt-nv merged 2 commits into
NVIDIA:mainfrom
achartier:fix-cbts-perf-sanity-post-merge
May 28, 2026
Merged

[None][fix] Exclude post-merge stages from CBTS force-keep filters#14594
tburt-nv merged 2 commits into
NVIDIA:mainfrom
achartier:fix-cbts-perf-sanity-post-merge

Conversation

@achartier

@achartier achartier commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Refined test stage filtering logic in CI/CD pipeline to improve handling of post-merge test execution.

Review Change Stack

Description

CBTS force-keep patterns (PerfSanity, PackageSanityCheck) matched post-merge stages by name, causing them to run in pre-merge CI pipelines. Add a top-level guard so Post-Merge stages are only included when explicitly listed in affected_stages.

Follow up to #13382

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

CBTS force-keep patterns (PerfSanity, PackageSanityCheck) matched
post-merge stages by name, causing them to run in pre-merge CI
pipelines. Add a top-level guard so Post-Merge stages are only
included when explicitly listed in affected_stages.

Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
@achartier
achartier requested review from a team, EmmaQiaoCh, QiJune and crazydemo May 26, 2026 17:55
@achartier
achartier requested a review from a team as a code owner May 26, 2026 17:55
@achartier
achartier requested a review from ZhanruiSunCh May 26, 2026 17:55
@achartier

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1fe449a8-df77-4859-ada5-82b300ed403e

📥 Commits

Reviewing files that changed from the base of the PR and between 6130b2a and 7088fbc.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy

📝 Walkthrough

Walkthrough

This PR modifies the CBTS stage-filtering logic in the Jenkins test launcher to add a condition for Post-Merge stages. When a stage key matches /Post-Merge/, the stage is now included only if it exists in affectedSet, aligning with existing filtering patterns.

Changes

CBTS Post-Merge Stage Filtering

Layer / File(s) Summary
Post-Merge stage filtering condition
jenkins/L0_Test.groovy
Adds a /Post-Merge/-specific branch in CBTS filtering so that matching Post-Merge stages are included only when affectedSet contains the stage key.

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains the issue and solution, but the Test Coverage section is empty and the PR checklist is incomplete regarding specific testing details for the code change. Add details to the Test Coverage section specifying what tests validate the post-merge stage filtering behavior, and ensure the PR checklist reflects the actual testing performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly specifies the main change: excluding post-merge stages from CBTS force-keep filters, which matches the core functionality described in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50373 [ run ] triggered by Bot. Commit: 6074329 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50373 [ run ] completed with state SUCCESS. Commit: 6074329
/LLM/main/L0_MergeRequest_PR pipeline #39900 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@crazydemo crazydemo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@achartier

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50436 [ run ] triggered by Bot. Commit: 6074329 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50436 [ run ] completed with state SUCCESS. Commit: 6074329
/LLM/main/L0_MergeRequest_PR pipeline #39958 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@achartier

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50568 [ run ] triggered by Bot. Commit: 6074329 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50568 [ run ] completed with state FAILURE. Commit: 6074329
/LLM/main/L0_MergeRequest_PR pipeline #40070 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@achartier

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50610 [ run ] triggered by Bot. Commit: 6074329 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50610 [ run ] completed with state SUCCESS. Commit: 6074329
/LLM/main/L0_MergeRequest_PR pipeline #40103 completed with status: 'SUCCESS'

CI Report

Link to invocation

@tburt-nv
tburt-nv merged commit e173446 into NVIDIA:main May 28, 2026
7 checks passed
@achartier
achartier deleted the fix-cbts-perf-sanity-post-merge branch May 28, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants