[None][fix] Bypass FlashInfer SSD prefill to fix state dtype precision - #14600
Conversation
The FlashInfer SSD prefill path (added in PR NVIDIA#12731) hardcodes state_dtype=bfloat16 in the SSDCombined kernel, while the Triton path accumulates states in float32 (states_in_fp32=True). This silently drops state accumulation precision on Blackwell (SM100+), which can cause accuracy drift for long sequences. Disable the FlashInfer dispatch so mamba_chunk_scan_combined always uses the Triton SSD kernels for prefill. The FlashInfer code is preserved for re-enablement once state_dtype is fixed to float32. Signed-off-by: tijyojwad <1127155+tijyojwad@users.noreply.github.com>
|
/bot run --disable-fail-fast |
📝 WalkthroughWalkthroughThe PR disables the FlashInfer SSD prefill optimization in the Mamba module by introducing an explicit ChangesFlashInfer SSD Prefill Disabling
🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #50404 [ run ] triggered by Bot. Commit: |
|
/bot run |
|
PR_Github #50407 [ run ] triggered by Bot. Commit: |
|
PR_Github #50407 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #50501 [ run ] triggered by Bot. Commit: |
|
PR_Github #50501 [ run ] completed with state |
NVIDIA#14600) Signed-off-by: tijyojwad <1127155+tijyojwad@users.noreply.github.com>
The FlashInfer SSD prefill path (added in PR #12731) hardcodes state_dtype=bfloat16 in the SSDCombined kernel, while the Triton path accumulates states in float32 (states_in_fp32=True). This silently drops state accumulation precision on Blackwell (SM100+), which can cause accuracy drift for long sequences.
Disable the FlashInfer dispatch so mamba_chunk_scan_combined always uses the Triton SSD kernels for prefill. The FlashInfer code is preserved for re-enablement once state_dtype is fixed to float32.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.