[https://nvbugs/6094100][fix] add ucx tls env in disagg related tests - #14626
Merged
Conversation
Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
chuangz0
force-pushed
the
test_disagg_worker_add_env
branch
from
May 27, 2026 09:19
aa85131 to
70b730b
Compare
Collaborator
Author
|
/bot run --disable-fail-fast |
Contributor
📝 WalkthroughWalkthroughThis PR adds dynamic UCX transport configuration to disaggregated integration tests by introducing a ChangesUCX Transport Dynamic Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
PR_Github #50518 [ run ] triggered by Bot. Commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
tests/integration/defs/disaggregated/test_workers.py (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required NVIDIA copyright/SPDX header to this modified file.
The file is modified but does not include the mandated header.
Suggested fix
+ # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. + # SPDX-License-Identifier: Apache-2.0 + import asyncioAs per coding guidelines: "
**/*.{cpp,cc,h,hpp,py,cu,cuh}: Include NVIDIA copyright header on ALL new files; update year on modified files."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/defs/disaggregated/test_workers.py` at line 1, This modified test file is missing the required NVIDIA copyright/SPDX header; add the standard multi-line NVIDIA copyright header and SPDX license identifier at the very top of the file (above the existing import asyncio), and update the year range in the header to include the current modification year so the file complies with the coding guidelines.tests/integration/defs/disaggregated/test_disaggregated_etcd.py (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUpdate the modified-file copyright year in the header.
This file was changed, but the header still ends at 2024.
Suggested fix
-# SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.As per coding guidelines: "
**/*.{cpp,cc,h,hpp,py,cu,cuh}: Include NVIDIA copyright header on ALL new files; update year on modified files."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/defs/disaggregated/test_disaggregated_etcd.py` at line 1, The SPDX header's copyright year range (the line containing "SPDX-FileCopyrightText") was not updated after modifying the file; update that header in this file (the SPDX-FileCopyrightText line) to reflect the current year by changing the trailing year from 2024 to 2026 (e.g., "2022-2026") so the file header correctly shows the updated modification year.
🧹 Nitpick comments (4)
tests/integration/defs/disaggregated/test_workers.py (1)
30-30: ⚡ Quick winAdd a return type annotation to
get_ucx_tls.Please annotate it as returning
str.Suggested fix
-def get_ucx_tls(): +def get_ucx_tls() -> str:As per coding guidelines: "Always annotate Python functions with return type; use
Noneif the function does not return anything."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/defs/disaggregated/test_workers.py` at line 30, Annotate the function signature for get_ucx_tls with an explicit return type of str (i.e., change its definition to include -> str) so the function declaration reads with a return type annotation; update the get_ucx_tls function declaration accordingly and ensure any related docstrings or type hints remain consistent.tests/integration/defs/disaggregated/test_disaggregated_etcd.py (1)
29-29: ⚡ Quick winAdd an explicit return type to the new helper.
Please annotate
get_ucx_tlswith-> str.Suggested fix
-def get_ucx_tls(): +def get_ucx_tls() -> str:As per coding guidelines: "Always annotate Python functions with return type; use
Noneif the function does not return anything."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/defs/disaggregated/test_disaggregated_etcd.py` at line 29, Annotate the helper function get_ucx_tls with an explicit return type by changing its signature to include "-> str" (i.e., declare get_ucx_tls returns a str) so the function follows the project's typing guideline for return annotations; update the function definition in tests/integration/defs/disaggregated/test_disaggregated_etcd.py accordingly.tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py (2)
287-289: QA list follow-up: no update needed for this cohort.These changes adjust runtime env for existing disaggregated tests but do not add new pytest node IDs; QA list file updates are unnecessary here as long as selectors/names remain unchanged.
As per coding guidelines: "If the change adds or materially alters an integration test under tests/integration/defs/... call out whether an entry is needed under tests/integration/test_lists/qa/."
Also applies to: 436-438, 547-551, 638-640, 747-749, 853-855
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py` around lines 287 - 289, This change only adjusts the runtime env passed into the executor (the UCX_TLS via get_ucx_tls() and UCX_MM_ERROR_HANDLING) inside the executor context in tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py, so verify that no test function or pytest node id was renamed/added and therefore no update to tests/integration/test_lists/qa/* is required; if you did change any test names/selectors or added new tests, update the corresponding QA list entry, otherwise leave QA files untouched.
20-20: ⚡ Quick winAnnotate
get_ucx_tlsreturn type.Please declare
-> stron this helper.Suggested fix
-def get_ucx_tls(): +def get_ucx_tls() -> str:As per coding guidelines: "Always annotate Python functions with return type; use
Noneif the function does not return anything."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py` at line 20, Annotate the helper function get_ucx_tls with an explicit return type by changing its signature to include "-> str"; locate the get_ucx_tls definition and add the return type annotation so the function reads like "def get_ucx_tls() -> str:" ensuring it satisfies the project's function return-type requirement.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py`:
- Line 1: This file is missing the mandated NVIDIA copyright/SPDX header: add
the project's standard NVIDIA header block at the very top of
test_disaggregated_single_gpu.py (before any imports such as asyncio), update
the copyright year range to include the current modification year, and include
the required SPDX identifier exactly as used across the repo so the header
matches other modified Python files.
---
Outside diff comments:
In `@tests/integration/defs/disaggregated/test_disaggregated_etcd.py`:
- Line 1: The SPDX header's copyright year range (the line containing
"SPDX-FileCopyrightText") was not updated after modifying the file; update that
header in this file (the SPDX-FileCopyrightText line) to reflect the current
year by changing the trailing year from 2024 to 2026 (e.g., "2022-2026") so the
file header correctly shows the updated modification year.
In `@tests/integration/defs/disaggregated/test_workers.py`:
- Line 1: This modified test file is missing the required NVIDIA copyright/SPDX
header; add the standard multi-line NVIDIA copyright header and SPDX license
identifier at the very top of the file (above the existing import asyncio), and
update the year range in the header to include the current modification year so
the file complies with the coding guidelines.
---
Nitpick comments:
In `@tests/integration/defs/disaggregated/test_disaggregated_etcd.py`:
- Line 29: Annotate the helper function get_ucx_tls with an explicit return type
by changing its signature to include "-> str" (i.e., declare get_ucx_tls returns
a str) so the function follows the project's typing guideline for return
annotations; update the function definition in
tests/integration/defs/disaggregated/test_disaggregated_etcd.py accordingly.
In `@tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py`:
- Around line 287-289: This change only adjusts the runtime env passed into the
executor (the UCX_TLS via get_ucx_tls() and UCX_MM_ERROR_HANDLING) inside the
executor context in
tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py, so verify
that no test function or pytest node id was renamed/added and therefore no
update to tests/integration/test_lists/qa/* is required; if you did change any
test names/selectors or added new tests, update the corresponding QA list entry,
otherwise leave QA files untouched.
- Line 20: Annotate the helper function get_ucx_tls with an explicit return type
by changing its signature to include "-> str"; locate the get_ucx_tls definition
and add the return type annotation so the function reads like "def get_ucx_tls()
-> str:" ensuring it satisfies the project's function return-type requirement.
In `@tests/integration/defs/disaggregated/test_workers.py`:
- Line 30: Annotate the function signature for get_ucx_tls with an explicit
return type of str (i.e., change its definition to include -> str) so the
function declaration reads with a return type annotation; update the get_ucx_tls
function declaration accordingly and ensure any related docstrings or type hints
remain consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e609413b-5da6-4367-998c-25c4c8270e42
📒 Files selected for processing (4)
tests/integration/defs/disaggregated/test_disaggregated_etcd.pytests/integration/defs/disaggregated/test_disaggregated_single_gpu.pytests/integration/defs/disaggregated/test_workers.pytests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/waives.txt
Collaborator
|
PR_Github #50518 [ run ] completed with state |
chuangz0
enabled auto-merge (squash)
May 28, 2026 01:31
fredricz-20070104
approved these changes
May 28, 2026
fredricz-20070104
left a comment
fredricz-20070104
left a comment
Collaborator
There was a problem hiding this comment.
No major issues. Approved
bmarimuthu-nv
pushed a commit
to nv-auto-deploy/TensorRT-LLM
that referenced
this pull request
May 28, 2026
…NVIDIA#14626) Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.