[TRTLLM-12982][perf] remove sync after FlashInfer attention plan() - #14634
Conversation
|
/bot run |
|
/bot run |
📝 WalkthroughWalkthroughThis PR removes a single CUDA stream synchronization call from the FlashInfer ragged prefill planning code path that handles the case when no KV cache manager is provided, occurring before the validation and execution of the no-KV ragged planning routine. ChangesFlashInfer Ragged Prefill Synchronization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #50553 [ run ] triggered by Bot. Commit: |
yechank-nvidia
left a comment
There was a problem hiding this comment.
Thx for the catch!
|
PR_Github #50554 [ run ] triggered by Bot. Commit: |
|
PR_Github #50553 [ run ] completed with state |
|
PR_Github #50554 [ run ] completed with state
|
Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
|
/bot run |
|
PR_Github #50709 [ run ] triggered by Bot. Commit: |
|
PR_Github #50709 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #50755 [ run ] triggered by Bot. Commit: |
|
PR_Github #50755 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #50818 [ run ] triggered by Bot. Commit: |
|
PR_Github #50818 [ run ] completed with state
|
|
/bot run |
|
PR_Github #51004 [ run ] triggered by Bot. Commit: |
|
PR_Github #51004 [ run ] completed with state
|
|
/bot run |
|
PR_Github #51045 [ run ] triggered by Bot. Commit: |
|
PR_Github #51045 [ run ] completed with state |
Description
This sync appears not to be necessary.
Test Coverage
pytest -svx "accuracy/test_llm_api_pytorch_multimodal.py::TestNemotron_Nano_12B_V2_VL::test_auto_dtype"still succeeds.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit