Skip to content

[https://nvbugs/6165866][infra] Waive 1 failed cases for main in pre-merge 40081#14653

Merged
tburt-nv merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:taylor/waive_test_moe
May 28, 2026
Merged

[https://nvbugs/6165866][infra] Waive 1 failed cases for main in pre-merge 40081#14653
tburt-nv merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:taylor/waive_test_moe

Conversation

@taylor-yb-lee

@taylor-yb-lee taylor-yb-lee commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Bug(s): 6165866
Requested by: @taylor-yb-lee

@coderabbitai summary

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Bug(s): 6165866
Requested by: @taylor-yb-lee

Signed-off-by: Taylor Yeonbok Lee <249374542+taylor-yb-lee@users.noreply.github.com>
@taylor-yb-lee
taylor-yb-lee marked this pull request as ready for review May 28, 2026 00:35
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 83c1ff7f-e083-4eee-a334-f27cdc82d49a

📥 Commits

Reviewing files that changed from the base of the PR and between 1a52920 and a265b36.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR adds a single test waiver entry to skip the B200 MoE backend test filtered to TRTLLM during integration runs, with a reference to the associated nvbug tracking the failure.

Changes

Test Waiver Update

Layer / File(s) Summary
B200 MoE Backend Test Waiver
tests/integration/test_lists/waives.txt
A SKIP waiver entry is added for full:B200/unittest/_torch/modules/moe/test_moe_backend.py::test_moe_backend -k "TRTLLM" with reference https://nvbugs/6165866.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14007: Both PRs add a waiver entry to skip the same _torch/modules/moe/test_moe_backend.py::test_moe_backend test with -k "TRTLLM" for nvbugs/6165866.
  • NVIDIA/TensorRT-LLM#14515: Both PRs modify tests/integration/test_lists/waives.txt by adding waiver entries to skip specific failing tests.
  • NVIDIA/TensorRT-LLM#13504: Both PRs modify the waiver file by appending additional SKIP entries, including B200 MoE TRTLLM test cases.

Suggested reviewers

  • yiqingy0
  • 2ez4bz
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete, missing the 'Description' and 'Test Coverage' sections that explain the issue and relevant tests. Add details in the 'Description' section explaining why the test is being waived, and list the affected test in 'Test Coverage'.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the NVBugs ticket and uses the correct [infra] type, accurately describing the main change of waiving a failed test case.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@taylor-yb-lee

Copy link
Copy Markdown
Collaborator Author

/bot run

@tburt-nv

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive only"

@tburt-nv
tburt-nv enabled auto-merge (squash) May 28, 2026 17:48
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50849 [ run ] triggered by Bot. Commit: a265b36 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50850 [ skip ] triggered by Bot. Commit: a265b36 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50849 [ run ] completed with state ABORTED. Commit: a265b36

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50850 [ skip ] completed with state SUCCESS. Commit: a265b36
Skipping testing for commit a265b36

Link to invocation

@tburt-nv
tburt-nv merged commit da9db3a into NVIDIA:main May 28, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants