[None][fix] fix FA4 install in devel docker - #14706
Conversation
|
/bot run --disable-fail-fast |
|
Actionable comments posted: 0 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds flash-attn-4 support to the Docker build pipeline. A new installer script is created to pin flash-attn-4 to version 4.0.0b11 with optional NVIDIA Artifactory mirror routing. The Dockerfile.multi devel stage is updated to invoke this script after the existing etcd installation step. ChangesFlash-Attn-4 Installation Support
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #50876 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #50912 [ run ] triggered by Bot. Commit: |
|
PR_Github #50876 [ run ] completed with state |
|
PR_Github #50912 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #51118 [ run ] triggered by Bot. Commit: |
|
PR_Github #51118 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #51403 [ run ] triggered by Bot. Commit: |
|
PR_Github #51403 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #51655 [ run ] triggered by Bot. Commit: |
|
PR_Github #51655 [ run ] completed with state
|
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #51664 [ run ] triggered by Bot. Commit: |
|
PR_Github #51664 [ run ] completed with state
|
|
PR_Github #53622 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #53671 [ run ] triggered by Bot. Commit: |
|
PR_Github #53671 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #53708 [ run ] triggered by Bot. Commit: |
|
PR_Github #53708 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #54360 [ run ] triggered by Bot. Commit: |
|
PR_Github #54360 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #54629 [ run ] triggered by Bot. Commit: |
|
PR_Github #54629 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #55044 [ run ] triggered by Bot. Commit: |
|
PR_Github #55044 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #55080 [ run ] triggered by Bot. Commit: |
|
PR_Github #55080 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #55330 [ run ] triggered by Bot. Commit: |
|
PR_Github #55330 [ run ] completed with state
|
Signed-off-by: Olivia Stoner <245287810+o-stoner@users.noreply.github.com>
|
/bot run |
|
PR_Github #55555 [ run ] triggered by Bot. Commit: |
|
PR_Github #55555 [ run ] completed with state |
Signed-off-by: Olivia Stoner <245287810+o-stoner@users.noreply.github.com>
Summary by CodeRabbit
Description
FA4's wheel ships only
flash_attn/cute/(no top-levelflash_attn/__init__.py), so it must share a directory with the base image's FlashAttention. A non-root pip install introduced in #13788 lands FA4 in~/.local, separate from the system FlashAttention, soflash_attn.cutecan't be found (ModuleNotFoundError) in VisualGen. Pre-install FA4 in the devel image as root, co-located with FlashAttention, so it is functional.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.