Skip to content

[https://nvbugs/6185480][fix] autodeploy unwaive the test - #14716

Merged
nvchenghaoz merged 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:chenghao/waive_0528
May 29, 2026
Merged

[https://nvbugs/6185480][fix] autodeploy unwaive the test#14716
nvchenghaoz merged 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:chenghao/waive_0528

Conversation

@nvchenghaoz

@nvchenghaoz nvchenghaoz commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed test waivers from the exclusion list, allowing previously skipped validation tests to run again.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 11e0912a-b137-47b0-ba5a-b9826d3101e2

📥 Commits

Reviewing files that changed from the base of the PR and between f6ba936 and 329bf1d.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR removes two test waiver entries from the integration test list. The entries waived TestGLM4Flash::test_auto_dtype tests on A100 hardware for both trtllm=False and trtllm=True configurations. These tests are no longer marked as expected failures.

Changes

Test waiver cleanup

Layer / File(s) Summary
Remove GLM4Flash A100 test waivers
tests/integration/test_lists/waives.txt
Remove two waiver entries for full:A100/accuracy/test_llm_api_autodeploy.py::TestGLM4Flash::test_auto_dtype with trtllm=False and trtllm=True configurations from the integration test waiver list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14221: Modifies the same waiver list file by adding/removing waived test entries for integration tests.
  • NVIDIA/TensorRT-LLM#13790: Modifies tests/integration/test_lists/waives.txt to change test waiver entries for the same accuracy/test_llm_api_autodeploy.py test file.
  • NVIDIA/TensorRT-LLM#14541: Modifies the same waiver list file by removing test skip entries for specific accuracy tests.

Suggested reviewers

  • jieli-matrix
  • xinhe-nv
  • LarryXFly
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete - it contains only the template with all sections left blank or unchecked, lacking any explanation of the issue, solution, or test coverage details. Fill in the Description and Test Coverage sections to explain why the test waiver is being removed and how the change is validated.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title correctly references the NVBugs ID and describes the main change (unwaiving a test), which aligns with the PR's objective of removing test waivers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@nvchenghaoz

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "unwaive a QA test only. No CI related test involved."

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50919 [ skip ] triggered by Bot. Commit: 329bf1d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50919 [ skip ] completed with state SUCCESS. Commit: 329bf1d
Skipping testing for commit 329bf1d

Link to invocation

Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
@nvchenghaoz
nvchenghaoz enabled auto-merge (squash) May 29, 2026 17:47
@nvchenghaoz

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "unwaive a QA test only. No CI related test involved."

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51083 [ skip ] triggered by Bot. Commit: 2591e09 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51083 [ skip ] completed with state SUCCESS. Commit: 2591e09
Skipping testing for commit 2591e09

Link to invocation

@nvchenghaoz
nvchenghaoz merged commit 027eb72 into NVIDIA:main May 29, 2026
8 checks passed
@nvchenghaoz
nvchenghaoz deleted the chenghao/waive_0528 branch May 29, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants