[TRTLLM-11410][feat] Cosmos3 Support - #14824
Conversation
📝 WalkthroughWalkthroughThis PR adds support for NVIDIA's Cosmos3 visual generation models (Nano and Super variants) to TensorRT-LLM. Changes include pipeline registration with Hugging Face model IDs, YAML configuration templates for single and multi-GPU deployments, a CLI example script for text-to-video/image-to-video generation, and documentation updates listing the new supported models and their capabilities. ChangesCosmos3 Visual Generation Feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/visual_gen/models/cosmos3_ti2v.py`:
- Line 78: Update the function signature for main by adding an explicit return
type annotation; change the definition of the top-level function main (def
main()) to def main() -> None: so it conforms to the project's typing rule,
leaving the body unchanged and ensuring no implicit return values are returned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 84a37da3-55d0-4db8-81e8-df09db376217
📒 Files selected for processing (5)
docs/source/models/visual-generation.mdexamples/visual_gen/configs/cosmos3-nano-1gpu.yamlexamples/visual_gen/configs/cosmos3-super-4gpu.yamlexamples/visual_gen/models/cosmos3_ti2v.pytensorrt_llm/_torch/visual_gen/models/cosmos3/pipeline_cosmos3.py
c028dfd to
cf040bb
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #51443 [ run ] triggered by Bot. Commit: |
|
PR_Github #51443 [ run ] completed with state
|
chang-l
left a comment
There was a problem hiding this comment.
Can you please also update this doc: https://nvidia.github.io/TensorRT-LLM/1.3.0rc17/models/supported-models.html?
|
/bot run --disable-fail-fast |
|
PR_Github #51686 [ run ] triggered by Bot. Commit: |
|
PR_Github #51686 [ run ] completed with state
|
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
a66fdc9 to
d9d6e8b
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #51861 [ run ] triggered by Bot. Commit: |
|
PR_Github #51861 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #52098 [ run ] triggered by Bot. Commit: |
|
PR_Github #52098 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #52165 [ run ] triggered by Bot. Commit: |
|
PR_Github #52165 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #52235 [ run ] triggered by Bot. Commit: |
|
PR_Github #52235 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #52352 [ run ] triggered by Bot. Commit: |
|
/bot kill |
|
PR_Github #52354 [ kill ] triggered by Bot. Commit: |
|
/bot skip --comment "PR only adds docs and examples, tests are run on B200 which pass. failures are GB200 which are unrelated" |
|
PR_Github #52352 [ run ] completed with state |
|
PR_Github #52354 [ kill ] completed with state |
|
PR_Github #52356 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52356 [ skip ] completed with state |
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com> Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Summary by CodeRabbit
New Features
Documentation
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.