Skip to content

[TRTLLM-11410][feat] Cosmos3 Support - #14824

Merged
NVShreyas merged 7 commits into
NVIDIA:mainfrom
NVShreyas:user/shreyasm/cosmos3
Jun 5, 2026
Merged

[TRTLLM-11410][feat] Cosmos3 Support#14824
NVShreyas merged 7 commits into
NVIDIA:mainfrom
NVShreyas:user/shreyasm/cosmos3

Conversation

@NVShreyas

@NVShreyas NVShreyas commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added support for NVIDIA Cosmos3-Nano and Cosmos3-Super diffusion models with FP8 dynamic quantization
    • Added example scripts and multi-GPU configurations for Cosmos3 text-to-video and text+image-to-video generation
  • Documentation

    • Updated supported models documentation with Cosmos3 feature matrix and capability specifications

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@NVShreyas
NVShreyas requested review from a team as code owners June 1, 2026 14:06
@NVShreyas
NVShreyas requested review from chang-l and kaiyux June 1, 2026 14:06
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds support for NVIDIA's Cosmos3 visual generation models (Nano and Super variants) to TensorRT-LLM. Changes include pipeline registration with Hugging Face model IDs, YAML configuration templates for single and multi-GPU deployments, a CLI example script for text-to-video/image-to-video generation, and documentation updates listing the new supported models and their capabilities.

Changes

Cosmos3 Visual Generation Feature

Layer / File(s) Summary
Pipeline registration and metadata
tensorrt_llm/_torch/visual_gen/models/cosmos3/pipeline_cosmos3.py
Cosmos3OmniMoTPipeline decorator is updated to include explicit Hugging Face model IDs and a documentation string, removing the prior TODO and completing the pipeline metadata.
Configuration templates for different hardware setups
examples/visual_gen/configs/cosmos3-nano-1gpu.yaml, examples/visual_gen/configs/cosmos3-super-4gpu.yaml
Two new YAML configs provide quantization (FP8 dynamic), attention backend (VANILLA), and parallelism parameters tailored for 1-GPU and 4-GPU deployments.
CLI example script and documentation updates
examples/visual_gen/models/cosmos3_ti2v.py, docs/source/models/visual-generation.md
A new CLI script demonstrates text-to-video and image-to-video generation with argparse options for model selection, config loading, and output saving. Documentation tables are updated to list Cosmos3-Nano and Cosmos3-Super as supported models with their feature capabilities.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

VisualGen

Suggested reviewers

  • chang-l
  • arysef
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is completely empty of actual content—only the repository template is present with no filled-in sections for description, test coverage, or checklist items. Fill in the Description section explaining what Cosmos3 support includes, provide Test Coverage details listing relevant tests, and complete the PR Checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and specifically identifies Cosmos3 support as the main feature being added across multiple files and configurations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@examples/visual_gen/models/cosmos3_ti2v.py`:
- Line 78: Update the function signature for main by adding an explicit return
type annotation; change the definition of the top-level function main (def
main()) to def main() -> None: so it conforms to the project's typing rule,
leaving the body unchanged and ensuring no implicit return values are returned.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 84a37da3-55d0-4db8-81e8-df09db376217

📥 Commits

Reviewing files that changed from the base of the PR and between 06456e1 and 685b570.

📒 Files selected for processing (5)
  • docs/source/models/visual-generation.md
  • examples/visual_gen/configs/cosmos3-nano-1gpu.yaml
  • examples/visual_gen/configs/cosmos3-super-4gpu.yaml
  • examples/visual_gen/models/cosmos3_ti2v.py
  • tensorrt_llm/_torch/visual_gen/models/cosmos3/pipeline_cosmos3.py

Comment thread examples/visual_gen/models/cosmos3_ti2v.py
@NVShreyas
NVShreyas force-pushed the user/shreyasm/cosmos3 branch 2 times, most recently from c028dfd to cf040bb Compare June 1, 2026 16:58
@NVShreyas NVShreyas changed the title [None][feat] Cosmos3 Support [TRTLLM-11410][feat] Cosmos3 Support Jun 1, 2026
@NVShreyas

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51443 [ run ] triggered by Bot. Commit: b0c02da Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51443 [ run ] completed with state SUCCESS. Commit: b0c02da
/LLM/main/L0_MergeRequest_PR pipeline #40852 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chang-l chang-l left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docs/source/models/visual-generation.md Outdated
Comment thread tests/unittest/_torch/visual_gen/test_cosmos3_transformer.py
@NVShreyas

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51686 [ run ] triggered by Bot. Commit: a66fdc9 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51686 [ run ] completed with state SUCCESS. Commit: a66fdc9
/LLM/main/L0_MergeRequest_PR pipeline #41066 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

NVShreyas added 7 commits June 3, 2026 07:37
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
@NVShreyas
NVShreyas force-pushed the user/shreyasm/cosmos3 branch from a66fdc9 to d9d6e8b Compare June 3, 2026 14:39
@NVShreyas

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51861 [ run ] triggered by Bot. Commit: d9d6e8b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51861 [ run ] completed with state ABORTED. Commit: d9d6e8b

Link to invocation

@NVShreyas

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52098 [ run ] triggered by Bot. Commit: d9d6e8b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52098 [ run ] completed with state SUCCESS. Commit: d9d6e8b
/LLM/main/L0_MergeRequest_PR pipeline #41428 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@NVShreyas

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52165 [ run ] triggered by Bot. Commit: d9d6e8b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52165 [ run ] completed with state SUCCESS. Commit: d9d6e8b
/LLM/main/L0_MergeRequest_PR pipeline #41486 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@NVShreyas

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52235 [ run ] triggered by Bot. Commit: d9d6e8b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52235 [ run ] completed with state SUCCESS. Commit: d9d6e8b
/LLM/main/L0_MergeRequest_PR pipeline #41551 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@NVShreyas

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52352 [ run ] triggered by Bot. Commit: d9d6e8b Link to invocation

@NVShreyas

Copy link
Copy Markdown
Collaborator Author

/bot kill

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52354 [ kill ] triggered by Bot. Commit: d9d6e8b Link to invocation

@NVShreyas

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "PR only adds docs and examples, tests are run on B200 which pass. failures are GB200 which are unrelated"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52352 [ run ] completed with state ABORTED. Commit: d9d6e8b

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52354 [ kill ] completed with state SUCCESS. Commit: d9d6e8b
Successfully killed previous jobs for commit d9d6e8b

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52356 [ skip ] triggered by Bot. Commit: d9d6e8b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52356 [ skip ] completed with state SUCCESS. Commit: d9d6e8b
Skipping testing for commit d9d6e8b

Link to invocation

@NVShreyas
NVShreyas merged commit 73c824c into NVIDIA:main Jun 5, 2026
7 checks passed
fbxai pushed a commit to fbxai/TensorRT-LLM that referenced this pull request Jun 5, 2026
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
2ez4bz pushed a commit to 2ez4bz/TensorRT-LLM that referenced this pull request Jun 8, 2026
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants