[https://nvbugs/6104831][test] PR #14768 rebased on latest main — perf-sanity verification (DO NOT REVIEW) - #14916
Draft
chienchunhung wants to merge 1 commit into
Draft
Conversation
…test main Verification PR — equivalent net diff of NVIDIA#14768 (A1+A2+A4+A7+A8 disagg tier-1 baseline) applied as a single commit on top of the latest upstream/main HEAD. Purpose: verify whether the perf-sanity regressions seen on NVIDIA#14768 (build #41014, #41125 — DeepSeek R1 FP4 V2 perf) are attributable to PR code or to branch staleness (32 commits behind main). Do NOT merge. Will be closed once CI signal is collected. Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-1, GB200-4_GPUs-PyTorch-PerfSanity-2" |
Collaborator
Author
|
/bot run --disable-fail-fast --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-1, GB200-4_GPUs-PyTorch-PerfSanity-2" |
Collaborator
|
PR_Github #51879 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #51879 [ run ] completed with state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose — verification only, NOT for merge
This PR is an experiment to isolate whether the perf-sanity regressions seen on PR #14768 (builds #40858, #41014, #41125 — DeepSeek R1 FP4 V2 on GB200) are attributable to PR #14768's code or to branch staleness.
What this PR contains
The net diff of PR #14768 (A1+A2+A4+A7+A8 disaggregated KV cache transceiver lifetime / RAII / dedup / NIXL keep-alive fixes), applied as a single squashed commit on top of the latest
upstream/mainHEAD.upstream/main(32 commits ahead of PR [https://nvbugs/6104831][fix] Enforce request and buffer index lifecycle integrity #14768's merge-base), pulling in recent fused-MoE / NVFP4 / speculative-decoding improvementsHypothesis being tested
PR #14768 fails 5 perf-sanity tests on GB200 against an auto-uploaded baseline:
aggr_upload-deepseek_r1_fp4_v2_grace_blackwell-r1_fp4_v2_tep4_mtp3_{1k1k,8k1k}aggr_upload-deepseek_r1_fp4_v2_grace_blackwell-r1_fp4_v2_tp4_mtp3_{1k1k,8k1k}aggr_upload-k25_thinking_fp4_grace_blackwell-k25_thinking_fp4_dep4_8k1kThe PR's diff only modifies disaggregated transceiver code paths (gated by
mCacheTransceiver != nullptr/if (self.kv_cache_transceiver):). The failing tests are aggregated-mode (aggr_upload-*) — config files intests/scripts/perf-sanity/aggregated/with nocache_transceiver_configfield — so PR #14768's modifications are not on the failing tests' execution path. Same tests pass onmainpostmerge (#2750, #2751, #2754) consistently.Hypothesis: the perf "regression" reflects baseline drift — main has perf improvements (~632 LOC in fused-MoE / NVFP4 / speculative since PR #14768's merge-base) that the auto-uploaded baseline reflects, but PR #14768's stale branch lacks. Rebasing should resolve the apparent regression.
How this will be verified
/bot run --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-1, GB200-4_GPUs-PyTorch-PerfSanity-2"— runs only the 5 failing tests.Will close this PR once the signal is collected.