Skip to content

[TRTLLMINF-69][infra] Migrate A100X-FMHA-Post-Merge-1 and A100X-Triton-Post-Merge-[1,2] to SLURM - #14921

Merged
mlefeb01 merged 3 commits into
NVIDIA:mainfrom
mlefeb01:migrate-a100
Jun 4, 2026
Merged

[TRTLLMINF-69][infra] Migrate A100X-FMHA-Post-Merge-1 and A100X-Triton-Post-Merge-[1,2] to SLURM#14921
mlefeb01 merged 3 commits into
NVIDIA:mainfrom
mlefeb01:migrate-a100

Conversation

@mlefeb01

@mlefeb01 mlefeb01 commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated internal test infrastructure configuration for post-merge verification stages.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…SLURM

Signed-off-by: Matt Lefebvre <mlefebvre@nvidia.com>
@mlefeb01 mlefeb01 self-assigned this Jun 3, 2026
@mlefeb01
mlefeb01 requested a review from a team June 3, 2026 23:36
@mlefeb01
mlefeb01 requested a review from a team as a code owner June 3, 2026 23:36
@mlefeb01
mlefeb01 requested review from tburt-nv and yiqingy0 June 3, 2026 23:36
@mlefeb01 mlefeb01 changed the title [TRTLLMINF-69][infra] Migrate A100X-FMHA-Post-Merge-1 and A100X-Triton-Post-Merge-[1,2] to … [TRTLLMINF-69][infra] Migrate A100X-FMHA-Post-Merge-1 and A100X-Triton-Post-Merge-[1,2] to SLURM Jun 3, 2026
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR migrates A100X post-merge test stages from Kubernetes-based to SLURM-based execution in Jenkins configuration. The stages (A100X-Triton-Post-Merge-1/2 and A100X-FMHA-Post-Merge-1) are removed from the standard config and re-added under SLURM, with the platform target updated to auto:dgx-a100-x1.

Changes

A100X Test Stage SLURM Migration

Layer / File(s) Summary
Migrate A100X post-merge stages to SLURM
jenkins/L0_Test.groovy
Removes three A100X post-merge test stage entries (A100X-Triton-Post-Merge-1/2, A100X-FMHA-Post-Merge-1) from the standard test configs and re-adds them to x86SlurmTestConfigs with platform target changed from a100x to auto:dgx-a100-x1, while preserving the l0_a100 YAML context and existing split/group counts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14661: Also modifies Jenkins stage configuration in jenkins/L0_Test.groovy by updating x86TestConfigs/x86SlurmTestConfigs entries and post-merge stage definitions.

Suggested reviewers

  • niukuo
  • zeroepoch
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is empty except for the template structure; no actual description, test coverage, or rationale is provided. Add a clear explanation of why A100X test stages are being migrated from Kubernetes to SLURM, what testing was performed, and confirm the PR checklist items are actually satisfied.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: migrating three A100X post-merge test stages from Kubernetes to SLURM infrastructure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mlefeb01

mlefeb01 commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --stage-list "A100X-Triton-Post-Merge-1,A100X-Triton-Post-Merge-2,A100X-FMHA-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51920 [ run ] triggered by Bot. Commit: de2fadb Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51920 [ run ] completed with state SUCCESS. Commit: de2fadb
/LLM/main/L0_MergeRequest_PR pipeline #41274 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

Comment thread jenkins/L0_Test.groovy Outdated
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Matt Lefebvre <matthewelefebvre@gmail.com>
@mlefeb01

mlefeb01 commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --stage-list "DGX_A100-Triton-Post-Merge-1,DGX_A100-Triton-Post-Merge-2,DGX_A100-FMHA-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52105 [ run ] triggered by Bot. Commit: 5b62a16 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52105 [ run ] completed with state SUCCESS. Commit: 5b62a16
/LLM/main/L0_MergeRequest_PR pipeline #41435 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@mlefeb01

mlefeb01 commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "DGX A100 tests passing"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52135 [ skip ] triggered by Bot. Commit: 7e9e3a7 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52135 [ skip ] completed with state SUCCESS. Commit: 7e9e3a7
Skipping testing for commit 7e9e3a7

Link to invocation

@mlefeb01
mlefeb01 merged commit 910826b into NVIDIA:main Jun 4, 2026
7 checks passed
@mlefeb01
mlefeb01 deleted the migrate-a100 branch June 4, 2026 18:58
fbxai pushed a commit to fbxai/TensorRT-LLM that referenced this pull request Jun 5, 2026
…n-Post-Merge-[1,2] to SLURM (NVIDIA#14921)

Signed-off-by: Matt Lefebvre <mlefebvre@nvidia.com>
Signed-off-by: Matt Lefebvre <matthewelefebvre@gmail.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
2ez4bz pushed a commit to 2ez4bz/TensorRT-LLM that referenced this pull request Jun 8, 2026
…n-Post-Merge-[1,2] to SLURM (NVIDIA#14921)

Signed-off-by: Matt Lefebvre <mlefebvre@nvidia.com>
Signed-off-by: Matt Lefebvre <matthewelefebvre@gmail.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
tensorrt-cicd pushed a commit that referenced this pull request Jun 11, 2026
… before MTP one-model merge)

Squashed probe equal to the tree of upstream commit 910826b
([TRTLLMINF-69][infra] Migrate A100X-FMHA/Triton Post-Merge to SLURM #14921),
the commit immediately before the suspected culprit 8e5d9e2, rebased onto its
parent a8c4007 so CI builds exactly that commit's tree.
Authored/signed-off by chenfeiz to satisfy DCO.

Signed-off-by: chenfeiz <chenfeiz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants