[None][infra] Waive 11 failed cases for main in post-merge 2757#14925
Conversation
Bug(s): 6160629, 6266259, 6266302, 6266306 Requested by: @EmmaQiaoCh Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughThis PR adds test skip waiver entries to ChangesTest Waivers Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
193-193: ⚡ Quick winCoverage is now insufficient in the newly waived suites; add explicit unwaive follow-up tracking.
Please add a follow-up item (outside this PR is fine) for each impacted file with owner/target date to restore CI signal:
tests/integration/disaggregated/test_disaggregated_single_gpu.py— coverage insufficienttests/integration/kv_cache/test_prefix_aware_scheduling.py— coverage insufficienttests/integration/unittest/_torch/multi_gpu/test_user_buffers.py— coverage insufficient (8 parametrized cases waived)tests/integration/unittest/auto_deploy/standalone/test_standalone_package.py— coverage insufficientGiven this is a waiver PR, the entries are format-correct, but these areas now need follow-up outside this PR to avoid long-lived blind spots.
Based on learnings, "In tests/integration/test_lists/waives.txt, prefer the short nvbug URL format https://nvbugs/XXXX ... ensure consistency by using the short form"; these new entries are consistent with that format.
Also applies to: 262-262, 338-345, 354-354
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 193, Add explicit follow-up tasks (outside this PR) to restore CI coverage for each waived test file by creating a tracker/ticket listing owner and target date: tests/integration/disaggregated/test_disaggregated_single_gpu.py, tests/integration/kv_cache/test_prefix_aware_scheduling.py, tests/integration/unittest/_torch/multi_gpu/test_user_buffers.py (note 8 parametrized cases waived), and tests/integration/unittest/auto_deploy/standalone/test_standalone_package.py; ensure each tracker references the waiver lines (e.g., the waives.txt entries around the mentioned ranges) and use the short nvbug URL format (https://nvbugs/XXXX) in waives.txt for consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 193: Add explicit follow-up tasks (outside this PR) to restore CI
coverage for each waived test file by creating a tracker/ticket listing owner
and target date:
tests/integration/disaggregated/test_disaggregated_single_gpu.py,
tests/integration/kv_cache/test_prefix_aware_scheduling.py,
tests/integration/unittest/_torch/multi_gpu/test_user_buffers.py (note 8
parametrized cases waived), and
tests/integration/unittest/auto_deploy/standalone/test_standalone_package.py;
ensure each tracker references the waiver lines (e.g., the waives.txt entries
around the mentioned ranges) and use the short nvbug URL format
(https://nvbugs/XXXX) in waives.txt for consistency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d6240949-c93a-4bd1-9b56-7f5d68f73d9c
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #51936 [ run ] triggered by Bot. Commit: |
|
/bot skip --comment "The previous CI passed check test list" |
|
PR_Github #51954 [ skip ] triggered by Bot. Commit: |
|
PR_Github #51936 [ run ] completed with state |
|
PR_Github #51954 [ skip ] completed with state |
…IA#14925) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @EmmaQiaoCh)
Target branch:
mainBug(s): 6160629, 6266259, 6266302, 6266306
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit