[None][fix] Update dataset identifier for cnn_dailymail to use namespaced repo in quantization scripts - #14930
Conversation
📝 WalkthroughWalkthroughThis PR adds dataset id remapping logic to two quantization dataloader functions to address HuggingFace Hub compatibility. When ChangesHuggingFace dataset id compatibility
Possibly related PRs
Suggested labels
Suggested reviewers
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tensorrt_llm/quantization/quantize_by_modelopt.py`:
- Around line 529-532: The remap for the "cnn_dailymail" dataset should point to
the canonical Hugging Face repo "abisee/cnn_dailymail" (and optionally pin the
documented revision 3.0.0) rather than "ccdv/cnn_dailymail"; update the
conditional in quantize_by_modelopt.py that handles dataset_name_or_dir (the
branches checking for "cnn_dailymail") to set dataset_name_or_dir =
"abisee/cnn_dailymail" (or "abisee/cnn_dailymail@3.0.0" if you want to pin the
version), and apply the same fix to both occurrences mentioned in the review
(the blocks around where dataset_name_or_dir is reassigned). Ensure the logic
still preserves the original intent of replacing the bare "cnn_dailymail" id.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 155ed7b2-48c7-475e-9660-e3862b0e0db0
📒 Files selected for processing (1)
tensorrt_llm/quantization/quantize_by_modelopt.py
…aced repo in quantization scripts Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
|
/bot run |
|
PR_Github #51957 [ run ] triggered by Bot. Commit: |
|
PR_Github #51957 [ run ] completed with state
|
|
/bot skip --comment "only test list modify" |
|
PR_Github #51979 [ skip ] triggered by Bot. Commit: |
|
PR_Github #51979 [ skip ] completed with state |
Signed-off-by: yufeiwu-nv 230315618+yufeiwu-nv@users.noreply.github.com
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.