[https://nvbugs/6248827][fix] Wrap both accesses in getattr(self.config, 'num_nextn_predict_layers', 0)… - #14932
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR refactors MTP weight detection in DeepseekV3 to handle missing config attributes gracefully, replacing a helper function with direct safe-default computation. It also updates test waivers for Mistral test parameterization. ChangesDeepseekV3 weight loading and test waiver updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
d121154 to
a975809
Compare
Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
a975809 to
c753b08
Compare
|
/bot run |
|
PR_Github #57788 [ run ] triggered by Bot. Commit: |
|
PR_Github #57788 [ run ] completed with state
|
|
Replaced by !15123 |
Pull request was closed
Summary
DeepseekV3WeightLoader.load_weightsunconditionally readsself.config.num_nextn_predict_layers, but_MistralPretrainedConfig(non-MTP, routed here since commit 651853b made MistralLarge3 delegate tosuper().load_weights) has no such attribute, raising AttributeError before weight loading.getattr(self.config, 'num_nextn_predict_layers', 0)(mirroring the existing precedent in modeling_exaone_moe.py:649-650), keeping the normal weight-load path running; also removed the now-fixed waiver (waives.txt:126).Test plan
Links
Summary by CodeRabbit
Bug Fixes
Tests