[https://nvbugs/6245317][test] set Harmony tiktoken env for GPT-OSS disagg - #14935
Conversation
74f8516 to
eff1338
Compare
|
/bot run --disable-fail-fast |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA test in the disaggregated integration test suite now sets up tiktoken cache environment variables before running the test. The environment is copied from ChangesTiktoken Environment Variables for Disaggregated Test
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #51970 [ run ] triggered by Bot. Commit: |
|
PR_Github #51970 [ run ] completed with state
|
eff1338 to
e787532
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #52122 [ run ] triggered by Bot. Commit: |
|
PR_Github #52122 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #52136 [ run ] triggered by Bot. Commit: |
|
PR_Github #52136 [ run ] completed with state
|
Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
e787532 to
cc549e8
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #52383 [ run ] triggered by Bot. Commit: |
|
PR_Github #52383 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #52443 [ run ] triggered by Bot. Commit: |
|
PR_Github #52443 [ run ] completed with state |
…isagg (NVIDIA#14935) Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Without this, tiktoken will try to download online and sometimes fail with
[05/26/2026-11:55:37] [TRT-LLM] [E] [serve] Error in harmony chat completion: %s error downloading or loading vocab file: failed to download or load vocab file
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.