Skip to content

[None][fix] AutoDeploy: Move hf_id_to_local_model_dir to function for GLM4.7 Flash test - #14999

Merged
bmarimuthu-nv merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:bala/glm-model-path-fix
Jun 5, 2026
Merged

[None][fix] AutoDeploy: Move hf_id_to_local_model_dir to function for GLM4.7 Flash test#14999
bmarimuthu-nv merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:bala/glm-model-path-fix

Conversation

@bmarimuthu-nv

@bmarimuthu-nv bmarimuthu-nv commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure to use Hugging Face model identifiers instead of precomputed model paths.
    • Modified test configurations for BF16 and NVFP4 dtype handling to derive model paths at runtime.
    • Preserved existing quantization settings while streamlining test setup.

Fixes: https://nvbugspro.nvidia.com/bug/6270692

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
@bmarimuthu-nv

Copy link
Copy Markdown
Collaborator Author

@CodeRabbit summary

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Summary regeneration triggered.

@bmarimuthu-nv bmarimuthu-nv changed the title [None][Fix] Move hf_id_to_local_model_dir to function for GLM4.7 Flash test [None][Fix] AutoDeploy: Move hf_id_to_local_model_dir to function for GLM4.7 Flash test Jun 5, 2026
@bmarimuthu-nv bmarimuthu-nv changed the title [None][Fix] AutoDeploy: Move hf_id_to_local_model_dir to function for GLM4.7 Flash test [None][fix] AutoDeploy: Move hf_id_to_local_model_dir to function for GLM4.7 Flash test Jun 5, 2026
@bmarimuthu-nv
bmarimuthu-nv marked this pull request as ready for review June 5, 2026 07:22
@bmarimuthu-nv
bmarimuthu-nv requested review from a team as code owners June 5, 2026 07:22
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The PR updates TestGLM4Flash to derive model directory paths at runtime from new Hugging Face ID constants and passes those derived paths into AutoDeployLLM in the BF16 and NVFP4 tests.

Changes

GLM4Flash HF ID-based path derivation

Layer / File(s) Summary
GLM4Flash test model path computation
tests/integration/defs/accuracy/test_llm_api_autodeploy.py
TestGLM4Flash introduces MODEL_HF_ID_BF16 and MODEL_HF_ID_NVFP4, and updates test_auto_dtype and test_nvfp4 to call hf_id_to_local_model_dir() to compute model_path at runtime and pass it as both model and tokenizer to AutoDeployLLM.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • suyoggupta
  • marinayanov
  • dpitman-nvda
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The pull request description is incomplete with no content in the Description, Test Coverage, or PR Checklist sections; only the template structure and a bug reference are provided. Provide a clear description of what was changed and why (the issue and solution), list the relevant tests that safeguard the changes, and complete the PR checklist items with actual answers or explanations.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the main change: refactoring hf_id_to_local_model_dir into a function for the GLM4.7 Flash test, which aligns with the raw summary describing runtime derivation of model_path.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bmarimuthu-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@fredricz-20070104 fredricz-20070104 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52291 [ run ] triggered by Bot. Commit: 81b59ef Link to invocation

@bmarimuthu-nv
bmarimuthu-nv enabled auto-merge (squash) June 5, 2026 07:31
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52291 [ run ] completed with state SUCCESS. Commit: 81b59ef
/LLM/main/L0_MergeRequest_PR pipeline #41600 completed with status: 'SUCCESS'

CI Report

Link to invocation

@bmarimuthu-nv
bmarimuthu-nv merged commit fdcdcb3 into NVIDIA:main Jun 5, 2026
24 of 28 checks passed
fbxai pushed a commit to fbxai/TensorRT-LLM that referenced this pull request Jun 5, 2026
… GLM4.7 Flash test (NVIDIA#14999)

Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
2ez4bz pushed a commit to 2ez4bz/TensorRT-LLM that referenced this pull request Jun 8, 2026
… GLM4.7 Flash test (NVIDIA#14999)

Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants