[TRTLLM-13259][ci] Merge DGX_H100 DeepSeek and GptOss stages - #15035
Conversation
…s into single stages Both stages are 2-way splits of a single same-backend test suite. The test set is selected purely from the stage name via mako (backend=pytorch plus auto_trigger), and sharding is applied separately, so collapsing splits=2 -> 1 runs the identical set of tests on one node while paying docker pull + pip install only once. - DGX_H100-4_GPUs-PyTorch-DeepSeek-1/2 -> DeepSeek-1 (1,1) - DGX_H100-2_GPUs-PyTorch-GptOss-1/2 -> GptOss-1 (1,1) Merged p99 stays well under the pre-merge critical path and the 4h stage cap, so there is no PR-turnaround impact while freeing one node per stage. Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
|
/bot run |
|
Ready to act? Review this PR in Change Stack to turn feedback into patch suggestions you can inspect and refine. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughSLURM test stage configurations in ChangesH100 PyTorch Test Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #52485 [ run ] triggered by Bot. Commit: |
|
PR_Github #52485 [ run ] completed with state
|
|
/bot run |
|
PR_Github #52511 [ run ] triggered by Bot. Commit: |
|
PR_Github #52511 [ run ] completed with state
|
|
/bot skip --comment "DGX_H100 DeepSeek and GptOss stages passed" |
|
PR_Github #52528 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52528 [ skip ] completed with state |
|
/bot skip --comment "DGX_H100 DeepSeek and GptOss stages passed" |
|
PR_Github #52539 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52539 [ skip ] completed with state |
Both stages are 2-way splits of a single same-backend test suite. The test set is selected purely from the stage name via mako (backend=pytorch plus auto_trigger), and sharding is applied separately, so collapsing splits=2 -> 1 runs the identical set of tests on one node while paying docker pull + pip install only once.
Merged p99 stays well under the pre-merge critical path and the 4h stage cap, so there is no PR-turnaround impact while freeing one node per stage.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.