[TRTLLM-13262][ci] Move non-default-feature tests to post merge - #15038
Conversation
|
Complex PR? Review this PR in Change Stack to move by importance, not file order. 📝 WalkthroughWalkthroughThis PR updates test configuration matrices across three hardware-specific test-db files for DeepSeekV3Lite model testing. Test entries are reorganized between pre-merge and post-merge stages and new parameter variant combinations are added, particularly focusing on MoE backend engines, tensor/expert parallelism, and optimization settings like CUDA graphs and torch compilation. ChangesDeepSeekV3Lite Test Matrix Reorganization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #52490 [ run ] triggered by Bot. Commit: |
|
PR_Github #52490 [ run ] completed with state
|
|
/bot run |
|
PR_Github #52512 [ run ] triggered by Bot. Commit: |
|
PR_Github #52512 [ run ] completed with state
|
|
/bot skip --comment "trivial changes" |
…ost-merge cuda_graph and overlap_scheduler are recommended default-on features, and the python_scheduler path is a non-default (P1) feature. The variants that disable these only need post-merge coverage, so move them out of pre_merge to free pre-merge GPU time without dropping coverage. Relocated DeepSeekV3Lite 4-GPU tests (pre_merge -> post_merge, same condition): - l0_gb200_multi_gpus.yml: 13 (nvfp4/bfloat16 cuda_graph=False/overlap_scheduler=False + python_scheduler) - l0_dgx_b200.yml: 4 python_scheduler (the pp4 cuda_graph=False test stays in pre_merge as the only pipeline-parallel smoke for that SKU) - l0_dgx_b300.yml: 1 (nvfp4 cuda_graph=False/overlap_scheduler=False) Also drop duplicate entries in l0_dgx_b200.yml that were listed in both pre_merge and post_merge (kept the appropriate stage for each): - TestNemotronUltraV3::test_accuracy[nvfp4-4] (kept pre-merge) - test_e2e[aggr_upload-super_ad_blackwell-super_ad_ws4_1k1k] (kept post-merge) Pure relocation/dedup: no coverage dropped; pre-merge retains the cuda_graph=True + overlap_scheduler=True configs plus the pp4 smoke. Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
|
/bot skip --comment "trivial changes" |
|
PR_Github #52677 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52677 [ skip ] completed with state |
cuda_graph and overlap_scheduler are recommended default-on features, and the python_scheduler path is a non-default (P1) feature. The variants that disable these only need post-merge coverage, so move them out of pre_merge to free pre-merge GPU time without dropping any coverage.
Relocated DeepSeekV3Lite 4-GPU tests (pre_merge -> post_merge, same condition):
Pure relocation: per-file test counts unchanged, no duplicates introduced. Pre-merge retains only the cuda_graph=True + overlap_scheduler=True configs.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.