[https://nvbugs/6194812][test] Update llm_perf_core.yml to require a minimum of 4 GPUs and add new performance tests - #15090
Conversation
…minimum of 4 GPUs and add new performance tests - Increased the minimum GPU count from 2 to 4 for llm_perf_core. - Added new performance test cases for qwen3 models with specific configurations. Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
|
/bot skip --comment "only test modify" |
1 similar comment
|
/bot skip --comment "only test modify" |
📝 WalkthroughWalkthroughThis PR updates the FP8 performance test configuration file to increase the minimum GPU count requirement from 2 to 4 and adds two new test cases for Qwen models configured with parallelism and scheduler overlap parameters. ChangesFP8 Performance Test Configuration
🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly Related PRs
Suggested Reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/qa/llm_perf_core.yml`:
- Line 25: The condition supports_fp8 in
tests/integration/test_lists/qa/llm_perf_core.yml currently sets
system_gpu_count: gte: 4 at the condition level, which unintentionally forces
every test under that condition to require 4+ GPUs; modify the YAML so
system_gpu_count: gte: 4 is removed from the top-level supports_fp8 condition
and instead add system_gpu_count: gte: 4 only to the individual test entries
that actually require 4 GPUs (or create a new sub-condition for
“requires_4_gpus” and attach it only to those tests); additionally verify the
two overlap scheduler entries that set maxnt: 2048 and input_output_len:
8000,1000 are deliberate by checking how maxnt is used in perf/test_perf.py and,
if needed, parameterize or document them so they match the perf runner’s
interpretation (adjust keys maxnt and input_output_len in the specific overlap
scheduler entries rather than changing the entire supports_fp8 condition).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: dc784088-1d4b-4384-aee0-7adf7c7d03bc
📒 Files selected for processing (1)
tests/integration/test_lists/qa/llm_perf_core.yml
|
PR_Github #52731 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52731 [ skip ] completed with state |
|
/bot skip --comment "only test modify" |
|
PR_Github #52981 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52981 [ skip ] completed with state |
|
/bot skip --comment "only test modify" |
|
PR_Github #52997 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52997 [ skip ] completed with state |
Signed-off-by: yufeiwu-nv 230315618+yufeiwu-nv@users.noreply.github.com
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.