Skip to content

[https://nvbugs/6244474][fix] AutoDeploy: Remove llama perf test from CI - #15107

Merged
MrGeva merged 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:eg/rm_llama
Jun 9, 2026
Merged

[https://nvbugs/6244474][fix] AutoDeploy: Remove llama perf test from CI#15107
MrGeva merged 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:eg/rm_llama

Conversation

@MrGeva

@MrGeva MrGeva commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

The test is unstable due to host boundness so currently removing it, and adding to the backlog to look into it as P1.

Summary by CodeRabbit

  • Tests
    • Updated H100 GPU test configuration for autodeploy accuracy testing.
    • Removed performance test waiver entry.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
@MrGeva
MrGeva marked this pull request as ready for review June 8, 2026 13:57
@MrGeva

MrGeva commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 84273fef-d778-45b5-b6d6-e354983e4137

📥 Commits

Reviewing files that changed from the base of the PR and between 2bf4d3d and f25966a.

📒 Files selected for processing (2)
  • tests/integration/test_lists/test-db/l0_h100.yml
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (2)
  • tests/integration/test_lists/waives.txt
  • tests/integration/test_lists/test-db/l0_h100.yml

📝 Walkthrough

Walkthrough

This PR removes a perf sanity test from H100 autodeploy configuration and replaces it with a new post_merge condition running accuracy tests for Llama3.1, Eagle3, and Nemotron models, while cleaning up the associated waiver entry.

Changes

H100 AutoDeploy Accuracy Migration

Layer / File(s) Summary
H100 autodeploy accuracy tests and waiver cleanup
tests/integration/test_lists/test-db/l0_h100.yml, tests/integration/test_lists/waives.txt
Removes perf/test_perf_sanity.py::test_e2e test entry from H100 autodeploy section, adds new post_merge H100/Ubuntu condition with backend: autodeploy and orchestrator: mpi running multiple accuracy/test_llm_api_autodeploy.py test cases (Llama3.1 auto-dtype, Eagle3 one-model, Nemotron variants), and removes the corresponding perf sanity waiver entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#15089: Removes the same waiver entry for the perf/test_perf_sanity.py::test_e2e[aggr_upload-llama3_1_8b_fp8_ad_hopper-llama3_1_8b_ad_ws1_1k1k] test that this PR also removes.
  • NVIDIA/TensorRT-LLM#15077: Modifies both tests/integration/test_lists/waives.txt and test configuration for perf sanity and accuracy tests in the same integration test suite.
  • NVIDIA/TensorRT-LLM#13925: Updates autodeploy accuracy test coverage and waiver entries with a similar focus on accuracy/test_llm_api_autodeploy.py test suite migration.

Suggested reviewers

  • xinhe-nv
  • StanleySun639
  • marinayanov
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete. While it provides a brief explanation of the issue (test instability due to host-boundness), required sections like 'Description', 'Test Coverage', and properly filled PR Checklist are missing or only partially completed. Fill in the 'Description' section with details about the instability, 'Test Coverage' to explain what tests validate this change, and complete the PR Checklist items specifically relevant to this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: removing an unstable llama performance test from the AutoDeploy CI pipeline.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch eg/rm_llama

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
@MrGeva

MrGeva commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@MrGeva
MrGeva enabled auto-merge (squash) June 8, 2026 14:19
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52791 [ run ] triggered by Bot. Commit: ff55df1 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52791 [ run ] completed with state FAILURE. Commit: ff55df1
/LLM/main/L0_MergeRequest_PR pipeline #42047 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@MrGeva

MrGeva commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52807 [ run ] triggered by Bot. Commit: ff55df1 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52807 [ run ] completed with state SUCCESS. Commit: ff55df1
/LLM/main/L0_MergeRequest_PR pipeline #42061 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@MrGeva

MrGeva commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52958 [ run ] triggered by Bot. Commit: ff55df1 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52958 [ run ] completed with state SUCCESS. Commit: ff55df1
/LLM/main/L0_MergeRequest_PR pipeline #42202 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@MrGeva

MrGeva commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

/bot help

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@MrGeva

MrGeva commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "only removing a test and unwaiving it (because it will no longer run anyway"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53049 [ skip ] triggered by Bot. Commit: ff55df1 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53049 [ skip ] completed with state SUCCESS. Commit: ff55df1
Skipping testing for commit ff55df1

Link to invocation

@MrGeva
MrGeva merged commit 104b9d7 into NVIDIA:main Jun 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants