[None][doc] Refine Nemotron Ultra doc - #15113
Conversation
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughThis PR updates the Key Models feature support matrix in the documentation by consolidating two separate ChangesNemotron Feature Support Matrix Update
Possibly related PRs
Suggested reviewers
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/models/supported-models.md`:
- Line 72: The consolidated table row for NemotronHForCausalLM currently
overstates support; update the `NemotronHForCausalLM` row in
docs/source/models/supported-models.md so that the "Attention Data Parallelism",
"Disaggregated Serving", and "KV Cache Reuse" columns are set to conservative
values (e.g., `Untested`) to match the `NemotronHForCausalLM (Super)` row, or
alternatively add a footnote clarifying that those features are only confirmed
for `NemotronHForCausalLM (Ultra)`; locate the consolidated
`NemotronHForCausalLM` table row and change the three column entries or append a
clarifying footnote referencing the `(Super)` vs `(Ultra)` rows.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 35b234d0-cc49-480d-919e-213508993f0f
📒 Files selected for processing (1)
docs/source/models/supported-models.md
|
PR_Github #52804 [ run ] triggered by Bot. Commit: |
|
PR_Github #52804 [ run ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.