Skip to content

[None][doc] Refine Nemotron Ultra doc - #15113

Merged
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/minor_update_nemotron_ultra_doc
Jun 8, 2026
Merged

[None][doc] Refine Nemotron Ultra doc#15113
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/minor_update_nemotron_ultra_doc

Conversation

@nv-guomingz

@nv-guomingz nv-guomingz commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Documentation
    • Updated the model support matrix to consolidate model variant entries, providing clearer visibility into feature support across model types.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
@nv-guomingz
nv-guomingz requested a review from a team as a code owner June 8, 2026 15:22
@nv-guomingz
nv-guomingz requested review from chang-l and kaiyux June 8, 2026 15:22
@nv-guomingz

Copy link
Copy Markdown
Collaborator Author

/bot run

@nv-guomingz
nv-guomingz enabled auto-merge (squash) June 8, 2026 15:24
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the Key Models feature support matrix in the documentation by consolidating two separate NemotronHForCausalLM entries (Super and Ultra variants) into a single row with revised feature support values for columns including Overlap Scheduler, Chunked Prefill, and Torch Sampler.

Changes

Nemotron Feature Support Matrix Update

Layer / File(s) Summary
Nemotron feature matrix consolidation
docs/source/models/supported-models.md
The Key Models feature support matrix consolidates two NemotronHForCausalLM variant rows (Super and Ultra) into a single entry with updated feature support flags.

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14964: Updates docs/source/models/supported-models.md to reflect Nemotron v3 Ultra support by changing the NemotronHForCausalLM (Ultra) feature-support matrix row.

Suggested reviewers

  • 2ez4bz
  • laikhtewari

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description consists entirely of the template structure with empty/placeholder sections (Description, Test Coverage) and uncompleted checklist items, providing no actual explanation of the changes. Fill in the Description section explaining what was changed and why, and provide relevant Test Coverage details or explain why none are needed for documentation-only changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates this is a documentation update for Nemotron Ultra, which directly relates to the consolidated NemotronHForCausalLM model matrix changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/source/models/supported-models.md`:
- Line 72: The consolidated table row for NemotronHForCausalLM currently
overstates support; update the `NemotronHForCausalLM` row in
docs/source/models/supported-models.md so that the "Attention Data Parallelism",
"Disaggregated Serving", and "KV Cache Reuse" columns are set to conservative
values (e.g., `Untested`) to match the `NemotronHForCausalLM (Super)` row, or
alternatively add a footnote clarifying that those features are only confirmed
for `NemotronHForCausalLM (Ultra)`; locate the consolidated
`NemotronHForCausalLM` table row and change the three column entries or append a
clarifying footnote referencing the `(Super)` vs `(Ultra)` rows.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 35b234d0-cc49-480d-919e-213508993f0f

📥 Commits

Reviewing files that changed from the base of the PR and between 9af8a16 and 0e4ec5a.

📒 Files selected for processing (1)
  • docs/source/models/supported-models.md

Comment thread docs/source/models/supported-models.md
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52804 [ run ] triggered by Bot. Commit: 0e4ec5a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52804 [ run ] completed with state SUCCESS. Commit: 0e4ec5a
/LLM/main/L0_MergeRequest_PR pipeline #42058 completed with status: 'SUCCESS'

CI Report

Link to invocation

@nv-guomingz
nv-guomingz merged commit 15d06c0 into NVIDIA:main Jun 8, 2026
14 of 15 checks passed
@nv-guomingz
nv-guomingz deleted the user/guomingz/minor_update_nemotron_ultra_doc branch June 8, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants