[None][test] Add support for nemotron_3_ultra_550b_nvfp4 model in performance tests and configurations - #15166
Conversation
|
/bot skip --comment "only test modify" |
…formance tests and configurations - Updated model paths to include nemotron_3_ultra_550b_nvfp4 in HF_MODEL_PATH. - Added configuration settings for nemotron_3_ultra_550b_nvfp4 in pytorch_model_config.py. - Included new performance test cases for nemotron_3_ultra_550b_nvfp4 in test_perf.py and updated llm_perf_core.yml. - Cleaned up legacy model name handling in test_perf.py. Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
|
PR_Github #53064 [ skip ] triggered by Bot. Commit: |
|
PR_Github #53064 [ skip ] completed with state |
…ts for nemotron and llama models - Reintroduced performance tests for nemotron_nano_12b_v2 and qwen3.5_27b models with various configurations. - Added performance tests for llama_v3.3_nemotron_super_49b with multiple input/output lengths and GPU configurations. - Ensured comprehensive coverage of performance benchmarks in the llm_perf_core.yml file. Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
📝 WalkthroughWalkthroughThis PR adds support for the NVIDIA Nemotron-3-Ultra-550B model to TensorRT-LLM performance testing infrastructure, refactors model directory and benchmark command generation logic, and reorganizes the GPU performance test matrix across multiple hardware and backend configurations. ChangesPerformance test infrastructure and Nemotron model support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/defs/perf/test_perf.py`:
- Around line 1042-1049: The build command list uses an unnecessary f-string for
a static literal; update the build_cmd construction (where self._build_script,
"--log_level=info", f"--workspace={engine_dir}", f"--model={model_name}",
f"--model_path={model_dir}", "build") by removing the leading f from the
"--log_level=info" item so it becomes a plain string; keep the other f-strings
for workspace, model and model_path that interpolate engine_dir, model_name and
model_dir respectively.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 49b63a26-7cc0-400f-8dec-10d15bd63e4a
📒 Files selected for processing (5)
tests/integration/defs/perf/_model_paths.pytests/integration/defs/perf/pytorch_model_config.pytests/integration/defs/perf/test_perf.pytests/integration/test_lists/qa/llm_perf_core.ymltests/integration/test_lists/test-db/l0_perf.yml
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/test-db/l0_perf.yml
- Removed redundant test cases for llama_v3.1_nemotron_ultra_253b and adjusted the configuration for qwen3.5_122b_a10b. - Added back performance tests for llama_v3.1_nemotron_ultra_253b with various input/output lengths and GPU configurations. - Updated comments for clarity on the test cases included. Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
|
/bot skip --comment "only test modify" |
Addresses CodeRabbit review: --log_level=info is a static literal and does not need an f-string prefix (ruff F541). Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
|
/bot skip --comment "only test modify" |
|
PR_Github #53250 [ skip ] triggered by Bot. Commit: |
|
PR_Github #53250 [ skip ] completed with state |
…#15166) NVIDIA#15166 was temporarily reverted in NVIDIA#15310. Reapply it here so the TensorRT perf test removal in l0_perf.yml lands together with the TensorRT stage/baseline cleanup in this PR, keeping the test list and Jenkins perf stages consistent. Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv 230315618+yufeiwu-nv@users.noreply.github.com
Summary by CodeRabbit
Release Notes
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.