[None][feat] AutoDeploy: enable attention-DP request balancer in SuperV3-MTP config - #15169
Closed
MrGeva wants to merge 1 commit into
Closed
[None][feat] AutoDeploy: enable attention-DP request balancer in SuperV3-MTP config#15169MrGeva wants to merge 1 commit into
MrGeva wants to merge 1 commit into
Conversation
…rV3-MTP config Enable the attention-DP request balancer (PyExecutor._balance_adp_requests) in the shipped super_v3_mtp.yaml via a top-level attention_dp_config block (enable_balance=true, batching_wait_iters=10, timeout_iters=16). The balancer is a no-op unless attention-DP is active (multi-GPU with enable_attention_dp). When active, it balances per-rank decode load so the busiest rank does not gate every MoE all-to-all collective step (the collective synchronizes all ranks), which otherwise inflates inter-token latency. Measured +64-111% output-token throughput at concurrency 128/256 on SuperV3-MTP NVFP4 attention-DP serving (SPEED-Bench). Trade-off: defers prefill, raising TTFT at high concurrency; tune batching_wait_iters / timeout_iters when first-token latency is the priority. The code default remains disabled (opt-in via config), so no behavior change for configs that do not set attention_dp_config. Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughSuperV3 MTP configuration now includes an ChangesAttention-DP Request Balancer Configuration
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly Related PRs
Suggested Reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables the attention-DP request balancer (
PyExecutor._balance_adp_requests) for the SuperV3-MTP AutoDeploy config by adding a top-levelattention_dp_configblock to the shippedexamples/auto_deploy/model_registry/configs/super_v3_mtp.yaml:Why
Under attention-DP, each MoE all-to-all is a collective that synchronizes all DP ranks every step. The rank holding the most sequences becomes a straggler that gates the collective, inflating inter-token latency. The balancer redistributes per-rank decode load so no single rank gates the collective.
Impact
batching_wait_iters/timeout_iterswhen first-token latency is the priority.Scope / safety
attention_dp_configare unaffected.enable_attention_dp). Single-GPU andattn_dp_offpaths are unchanged (the balancer requirestp_size > 1).TestNemotronSuperV3::test_accuracymatrix drivesenable_attention_dpvia adetect_shardingkwarg override, so bothattn_dp_offandattn_dp_onvariants continue to exercise this config correctly.Test Coverage
Covered by existing
accuracy/test_llm_api_autodeploy.py::TestNemotronSuperV3::test_accuracy[*-4-attn_dp_on-trtllm].🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes