[None][test] fix Cosmos3 tests after VisualGen config split by bobboli · Pull Request #15170 · NVIDIA/TensorRT-LLM

bobboli · 2026-06-09T16:08:25Z

Summary

update Cosmos3 tests to build model config through DiffusionPipelineConfig after the VisualGen config split
check quant config through the loaded transformer model config instead of the removed pipeline.model_config alias

Testing

pre-commit hooks on commit
python3 -m py_compile tests/unittest/_torch/visual_gen/test_cosmos3_transformer.py tests/unittest/_torch/visual_gen/test_cosmos3_pipeline.py
pytest not run locally: pytest is not installed in this shell

Summary by CodeRabbit

Tests
- Updated FP8 quantization configuration validation tests for visual generation to ensure proper verification of quantization settings within the pipeline architecture.

bobboli · 2026-06-09T16:13:17Z

/bot run

coderabbitai · 2026-06-09T16:15:00Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d8bf53e1-67fc-454a-8133-b8433aa3a8f4

📥 Commits

Reviewing files that changed from the base of the PR and between f0ba8c7 and 86c5519.

📒 Files selected for processing (2)

tests/unittest/_torch/visual_gen/test_cosmos3_pipeline.py
tests/unittest/_torch/visual_gen/test_cosmos3_transformer.py

📝 Walkthrough

Walkthrough

Two Cosmos3 visual generation test files are refactored to access model configuration through the transformer sub-object. The test helper is updated to load configuration via DiffusionPipelineConfig.from_pretrained().primary_model_config, and FP8 assertions in both test files are redirected from pipeline.model_config to pipeline.transformer.model_config.

Changes

Cosmos3 Test Configuration Access Path Refactoring

Layer / File(s)	Summary
Configuration loading and imports `tests/unittest/_torch/visual_gen/test_cosmos3_transformer.py`	Import block is expanded to include `DiffusionPipelineConfig` and `VisualGenArgs`, and `_load_model_config` helper now derives model configuration via `DiffusionPipelineConfig.from_pretrained(...).primary_model_config` instead of calling `DiffusionModelConfig.from_pretrained(...)` directly.
FP8 assertion path updates `tests/unittest/_torch/visual_gen/test_cosmos3_transformer.py`, `tests/unittest/_torch/visual_gen/test_cosmos3_pipeline.py`	FP8 quantization algorithm assertions in both transformer and pipeline tests are updated to read `quant_algo` from `pipeline.transformer.model_config.quant_config` instead of `pipeline.model_config.quant_config`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

kaiyux
chang-l

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies a test fix related to Cosmos3 tests after a VisualGen config split, matching the actual changes in the pull request.
Description check	✅ Passed	The description covers the main changes (VisualGen config split, model config construction, quant config access) and testing approach, but lacks detail on the specific issue and the Test Coverage section is incomplete.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2026-06-09T16:19:11Z

PR_Github #53096 [ run ] triggered by Bot. Commit: 86c5519 Link to invocation

tensorrt-cicd · 2026-06-09T21:10:58Z

PR_Github #53096 [ run ] completed with state FAILURE. Commit: 86c5519
/LLM/main/L0_MergeRequest_PR pipeline #42304 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

NVShreyas · 2026-06-09T21:59:38Z

/bot run

tensorrt-cicd · 2026-06-09T22:06:21Z

PR_Github #53157 [ run ] triggered by Bot. Commit: 86c5519 Link to invocation

tensorrt-cicd · 2026-06-10T02:52:46Z

PR_Github #53157 [ run ] completed with state FAILURE. Commit: 86c5519
/LLM/main/L0_MergeRequest_PR pipeline #42360 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

bobboli · 2026-06-10T04:25:33Z

/bot run

tensorrt-cicd · 2026-06-10T04:31:16Z

PR_Github #53227 [ run ] triggered by Bot. Commit: cd5e3fb Link to invocation

tensorrt-cicd · 2026-06-10T09:20:59Z

PR_Github #53227 [ run ] completed with state SUCCESS. Commit: cd5e3fb
/LLM/main/L0_MergeRequest_PR pipeline #42422 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

bobboli · 2026-06-10T09:53:07Z

/bot run --reuse-test

tensorrt-cicd · 2026-06-10T09:58:42Z

PR_Github #53296 [ run ] triggered by Bot. Commit: cd5e3fb Link to invocation

tensorrt-cicd · 2026-06-10T14:58:43Z

PR_Github #53296 [ run ] completed with state SUCCESS. Commit: cd5e3fb
/LLM/main/L0_MergeRequest_PR pipeline #42484 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

bobboli · 2026-06-10T15:03:18Z

/bot run --reuse-test

tensorrt-cicd · 2026-06-10T15:09:37Z

PR_Github #53324 [ run ] triggered by Bot. Commit: cd5e3fb Link to invocation

tensorrt-cicd · 2026-06-10T19:43:19Z

PR_Github #53324 [ run ] completed with state FAILURE. Commit: cd5e3fb
/LLM/main/L0_MergeRequest_PR pipeline #42510 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

bobboli · 2026-06-11T03:37:47Z

/bot run --reuse-test

tensorrt-cicd · 2026-06-11T03:43:21Z

PR_Github #53462 [ run ] triggered by Bot. Commit: cd5e3fb Link to invocation

tensorrt-cicd · 2026-06-11T08:17:35Z

PR_Github #53462 [ run ] completed with state SUCCESS. Commit: cd5e3fb
/LLM/main/L0_MergeRequest_PR pipeline #42626 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

NVShreyas · 2026-06-11T14:31:48Z

/bot run --reuse-test

tensorrt-cicd · 2026-06-11T14:38:41Z

PR_Github #53587 [ run ] triggered by Bot. Commit: cd5e3fb Link to invocation

tensorrt-cicd · 2026-06-11T18:10:34Z

PR_Github #53587 [ run ] completed with state SUCCESS. Commit: cd5e3fb
/LLM/main/L0_MergeRequest_PR pipeline #42733 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

tensorrt-cicd · 2026-06-12T16:27:38Z

PR_Github #53851 [ run ] completed with state SUCCESS. Commit: dfeb636
/LLM/main/L0_MergeRequest_PR pipeline #42959 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

NVShreyas · 2026-06-12T17:03:16Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-06-12T17:09:42Z

PR_Github #53920 [ run ] triggered by Bot. Commit: dfeb636 Link to invocation

tensorrt-cicd · 2026-06-12T19:39:25Z

PR_Github #53920 [ run ] completed with state SUCCESS. Commit: dfeb636
/LLM/main/L0_MergeRequest_PR pipeline #43015 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

NVShreyas · 2026-06-12T20:21:15Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-06-12T20:35:26Z

PR_Github #53950 [ run ] triggered by Bot. Commit: dfeb636 Link to invocation

tensorrt-cicd · 2026-06-13T01:17:40Z

PR_Github #53950 [ run ] completed with state FAILURE. Commit: dfeb636
/LLM/main/L0_MergeRequest_PR pipeline #43041 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

bobboli · 2026-06-15T10:57:44Z

/bot run --disable-fail-fast --reuse-test

tensorrt-cicd · 2026-06-15T11:03:51Z

PR_Github #54289 [ run ] triggered by Bot. Commit: dfeb636 Link to invocation

tensorrt-cicd · 2026-06-15T11:48:04Z

PR_Github #54289 [ run ] completed with state FAILURE. Commit: dfeb636
/LLM/main/L0_MergeRequest_PR pipeline #43360 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

NVShreyas · 2026-06-15T14:59:45Z

/bot run --disable-fail-fast --reuse-test

tensorrt-cicd · 2026-06-15T15:05:31Z

PR_Github #54316 [ run ] triggered by Bot. Commit: dfeb636 Link to invocation

tensorrt-cicd · 2026-06-15T19:42:09Z

PR_Github #54316 [ run ] completed with state SUCCESS. Commit: dfeb636
/LLM/main/L0_MergeRequest_PR pipeline #43387 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>

bobboli · 2026-06-18T05:06:37Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-06-18T05:14:34Z

PR_Github #54906 [ run ] triggered by Bot. Commit: 920fc36 Link to invocation

tensorrt-cicd · 2026-06-18T09:55:59Z

PR_Github #54906 [ run ] completed with state SUCCESS. Commit: 920fc36
/LLM/main/L0_MergeRequest_PR pipeline #43910 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

bobboli · 2026-06-18T14:45:36Z

/bot run --reuse-test

chang-l · 2026-06-23T17:40:07Z

/bot run

tensorrt-cicd · 2026-06-23T17:46:16Z

PR_Github #55301 [ run ] triggered by Bot. Commit: 920fc36 Link to invocation

tensorrt-cicd · 2026-06-23T22:34:05Z

PR_Github #55301 [ run ] completed with state SUCCESS. Commit: 920fc36
/LLM/main/L0_MergeRequest_PR pipeline #44251 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

chang-l · 2026-06-23T22:44:05Z

/bot run --reuse-test

tensorrt-cicd · 2026-06-23T22:49:47Z

PR_Github #55337 [ run ] triggered by Bot. Commit: 920fc36 Link to invocation

tensorrt-cicd · 2026-06-24T03:14:25Z

PR_Github #55337 [ run ] completed with state SUCCESS. Commit: 920fc36
/LLM/main/L0_MergeRequest_PR pipeline #44288 completed with status: 'SUCCESS'

CI Report

Link to invocation

…5170) Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com> Signed-off-by: GitLab CI Bot <gitlab-ci@nvidia.com>

…5170) Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>

bobboli requested a review from a team as a code owner June 9, 2026 16:08

github-actions Bot assigned bobboli Jun 9, 2026

bobboli enabled auto-merge (squash) June 9, 2026 16:13

NVShreyas approved these changes Jun 9, 2026

View reviewed changes

zhenhuaw-me approved these changes Jun 10, 2026

View reviewed changes

bobboli force-pushed the bli/fix-cosmos3-config-tests branch 2 times, most recently from 807fdf2 to 5cc2df9 Compare June 10, 2026 04:22

bobboli mentioned this pull request Jun 11, 2026

[https://nvbugs/6290965][fix] Rename model_config → pipeline_config on the two Cosmos3 test asserts and… #15263

Closed

2 tasks

bobboli added 2 commits June 18, 2026 13:04

[None][test] fix Cosmos3 tests after VisualGen config split

1d10cc8

Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>

[None][test] unwaive Cosmos3 B200 tests

920fc36

Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>

bobboli force-pushed the bli/fix-cosmos3-config-tests branch from dfeb636 to 920fc36 Compare June 18, 2026 05:05

bobboli merged commit aeb169a into NVIDIA:main Jun 24, 2026
7 checks passed

bobboli mentioned this pull request Jul 1, 2026

[https://nvbugs/6290962][fix] Replace the missing pipeline.model_config accessor with… #15196

Closed

2 tasks

BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026

[None][test] fix Cosmos3 tests after VisualGen config split (NVIDIA#1…

7159c8b

…5170) Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>

Uh oh!

Conversation

bobboli commented Jun 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

bobboli commented Jun 9, 2026

Uh oh!

coderabbitai Bot commented Jun 9, 2026

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

tensorrt-cicd commented Jun 9, 2026

Uh oh!

tensorrt-cicd commented Jun 9, 2026

Uh oh!

NVShreyas commented Jun 9, 2026

Uh oh!

tensorrt-cicd commented Jun 9, 2026

Uh oh!

tensorrt-cicd commented Jun 10, 2026

Uh oh!

bobboli commented Jun 10, 2026

Uh oh!

tensorrt-cicd commented Jun 10, 2026

Uh oh!

tensorrt-cicd commented Jun 10, 2026

Uh oh!

bobboli commented Jun 10, 2026

Uh oh!

tensorrt-cicd commented Jun 10, 2026

Uh oh!

tensorrt-cicd commented Jun 10, 2026

Uh oh!

bobboli commented Jun 10, 2026

Uh oh!

tensorrt-cicd commented Jun 10, 2026

Uh oh!

tensorrt-cicd commented Jun 10, 2026

Uh oh!

bobboli commented Jun 11, 2026

Uh oh!

tensorrt-cicd commented Jun 11, 2026

Uh oh!

tensorrt-cicd commented Jun 11, 2026

Uh oh!

NVShreyas commented Jun 11, 2026

Uh oh!

tensorrt-cicd commented Jun 11, 2026

Uh oh!

tensorrt-cicd commented Jun 11, 2026

Uh oh!

tensorrt-cicd commented Jun 12, 2026

Uh oh!

NVShreyas commented Jun 12, 2026

Uh oh!

tensorrt-cicd commented Jun 12, 2026

Uh oh!

tensorrt-cicd commented Jun 12, 2026

Uh oh!

NVShreyas commented Jun 12, 2026

Uh oh!

tensorrt-cicd commented Jun 12, 2026

Uh oh!

tensorrt-cicd commented Jun 13, 2026

Uh oh!

bobboli commented Jun 15, 2026

Uh oh!

tensorrt-cicd commented Jun 15, 2026

Uh oh!

tensorrt-cicd commented Jun 15, 2026

Uh oh!

NVShreyas commented Jun 15, 2026

Uh oh!

tensorrt-cicd commented Jun 15, 2026

bobboli commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading