Skip to content

[https://nvbugs/6256531][test] Unwaive Llama guided decoding xgrammar - #15240

Merged
sunnyqgg merged 2 commits into
NVIDIA:mainfrom
sunnyqgg:nv_bug_6256531
Jun 25, 2026
Merged

[https://nvbugs/6256531][test] Unwaive Llama guided decoding xgrammar#15240
sunnyqgg merged 2 commits into
NVIDIA:mainfrom
sunnyqgg:nv_bug_6256531

Conversation

@sunnyqgg

@sunnyqgg sunnyqgg commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Changes

  • Remove the SKIP waiver for accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_guided_decoding_4gpus[xgrammar] from tests/integration/test_lists/waives.txt.

Test plan

  • pre-commit run --files tests/integration/test_lists/waives.txt
  • CI: /bot run --disable-fail-fast

Summary by CodeRabbit

  • Tests
    • Removed a waived test entry to improve test maintenance.

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

One waived test entry for test_guided_decoding_4gpus[xgrammar] is removed from the test waiver list, consolidating the remaining waivers in the configuration file.

Changes

Test Waiver Removal

Layer / File(s) Summary
Remove xgrammar guided decoding waiver
tests/integration/test_lists/waives.txt
Deleted the waived test entry for accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_guided_decoding_4gpus[xgrammar] from the test skip list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • xinhe-nv
  • dpitman-nvda
  • yuanjingx87
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a test waiver for Llama guided decoding with xgrammar, directly aligned with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly explains the purpose (unwaiving a test), documents the specific change made, and includes a test plan with pre-commit validation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@sunnyqgg

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53449 [ run ] triggered by Bot. Commit: eec685a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53450 [ run ] triggered by Bot. Commit: eec685a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53449 [ run ] completed with state ABORTED. Commit: eec685a

Link to invocation

Signed-off-by: qgai <qgai@nvidia.com>

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53502 [ run ] triggered by Bot. Commit: fc23982 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53450 [ run ] completed with state ABORTED. Commit: eec685a

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53502 [ run ] completed with state FAILURE. Commit: fc23982
/LLM/main/L0_MergeRequest_PR pipeline #42662 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@sunnyqgg

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54391 [ run ] triggered by Bot. Commit: fc23982 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54391 [ run ] completed with state FAILURE. Commit: fc23982
/LLM/main/L0_MergeRequest_PR pipeline #43459 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@sunnyqgg

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55438 [ run ] triggered by Bot. Commit: 07f7db4 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55438 [ run ] completed with state SUCCESS. Commit: 07f7db4
/LLM/main/L0_MergeRequest_PR pipeline #44374 completed with status: 'SUCCESS'

CI Report

Link to invocation

@sunnyqgg
sunnyqgg requested a review from EmmaQiaoCh June 25, 2026 06:29
@sunnyqgg
sunnyqgg merged commit 948db5a into NVIDIA:main Jun 25, 2026
7 checks passed
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants