Skip to content

[None][test] Remove stale perf sanity waives - #15269

Merged
cascade812 merged 1 commit into
NVIDIA:mainfrom
cascade812:codex/cleanup-stale-waives
Jun 11, 2026
Merged

[None][test] Remove stale perf sanity waives#15269
cascade812 merged 1 commit into
NVIDIA:mainfrom
cascade812:codex/cleanup-stale-waives

Conversation

@cascade812

@cascade812 cascade812 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Re-enabled performance sanity validation checks for select system variants that were previously waived, allowing the test suite to provide improved performance monitoring coverage.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Guiju Zhang <guijuz@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Two waive entries for resolved perf test cases on gb300_deepseek-v32-fp4_1k1k variants are removed from the test waiver list in a single-file configuration update.

Changes

Test Waiver Updates

Layer / File(s) Summary
Remove waive entries for resolved perf test cases
tests/integration/test_lists/waives.txt
Waive entries for perf/test_perf_sanity.py::test_e2e on gb300_deepseek-v32-fp4_1k1k are removed under both disagg_upload-e2e and disagg_upload-gen_only scenarios.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#15061: Both PRs modify the same tests/integration/test_lists/waives.txt by removing/updating SKIP/waive entries for perf/test_perf_sanity.py::test_e2e cases (e.g., gb300_deepseek-v32-fp4_1k1k).
  • NVIDIA/TensorRT-LLM#15250: Both PRs modify tests/integration/test_lists/waives.txt to change which perf/test_perf_sanity.py::test_e2e disagg_upload-e2e/disagg_upload-gen_only DeepSeek V32 FP4 cases are skipped.
  • NVIDIA/TensorRT-LLM#15205: Both PRs edit tests/integration/test_lists/waives.txt to unwaive perf/test_perf_sanity.py::test_e2e disagg-upload gen-only cases.

Suggested reviewers

  • xinhe-nv
  • mzweilz
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is largely empty with only the template structure filled out; no actual description, test coverage details, or rationale provided. Add a meaningful description explaining why the stale waives are being removed, what test cases are affected, and any relevant context for the changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing stale perf sanity waives from the test waiver list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@cascade812

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Stale/non-existent test names in waives.txt, skip testing"

@cascade812
cascade812 enabled auto-merge (squash) June 11, 2026 18:09
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53637 [ skip ] triggered by Bot. Commit: 3fd25f9 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53637 [ skip ] completed with state SUCCESS. Commit: 3fd25f9
Skipping testing for commit 3fd25f9

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants