Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 42752 - #15270

Closed
ZhanruiSunCh wants to merge 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260611-183746
Closed

[None][infra] Waive 1 failed cases for main in pre-merge 42752#15270
ZhanruiSunCh wants to merge 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260611-183746

Conversation

@ZhanruiSunCh

@ZhanruiSunCh ZhanruiSunCh commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @2ez4bz)
Target branch: main
Bug(s): 6307150

Waive entries added

unittest/_torch/modeling/test_modeling_step3p7.py::TestStep3p7Checkpoint::test_config_and_weight_accounting_1_nvfp4 SKIP (https://nvbugs/6307150)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

  • Tests
    • Updated test configuration to skip a specific checkpoint test case due to an open issue being tracked internally.

Bug(s): 6307150
Requested by: @2ez4bz

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ae01ce5a-cc1a-45dd-8182-3259299198d1

📥 Commits

Reviewing files that changed from the base of the PR and between 19b5d0e and c289d58.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single test waiver entry is added to the integration test skip list for a Step3p7Checkpoint NVFP4 test case, referencing NVBug 6307150 for tracking purposes.

Changes

Test Waiver Update

Layer / File(s) Summary
Add Step3p7Checkpoint NVFP4 test waiver
tests/integration/test_lists/waives.txt
New SKIP waiver entry for unittest/_torch/modeling/test_modeling_step3p7.py::TestStep3p7Checkpoint::test_config_and_weight_accounting_1_nvfp4, linked to NVBug 6307150.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14204: Modifies the same waiver file by adding an NVFP4-related SKIP entry for a different Step3p7Checkpoint test case.
  • NVIDIA/TensorRT-LLM#14926: Updates the test_modeling_step3p7.py file directly to modify NVFP4 test behavior, targeting the same test case being waived here.
  • NVIDIA/TensorRT-LLM#15195: Also updates tests/integration/test_lists/waives.txt by adding new temporary test skip entries.

Suggested reviewers

  • moraxu
  • StanleySun639
  • yechank-nvidia
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title correctly follows the repository's convention with [None] ticket format and [infra] type, clearly indicating this is an infrastructure change adding waiver entries for failed test cases.
Description check ✅ Passed The description clearly explains the waive PR purpose, includes the auto-generated context, specifies the bug reference, and lists the waived test case. However, it does not follow the full repository template structure with explicit sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant