[None][fix] Fix AutoDeploy shim test expecting soft fallback for speculative+flashinfer - #15280
[None][fix] Fix AutoDeploy shim test expecting soft fallback for speculative+flashinfer#15280achartier wants to merge 1 commit into
Conversation
…r in AutoDeploy test_speculative_flashinfer_fallback_disables_piecewise was written expecting the old auto-correction behavior (silent fallback to torch-simple), but reject_cudagraph_for_speculative_flashinfer now hard-rejects the combination unless compile_backend is set explicitly. Pass compile_backend='torch-simple' and rename the test to match what it actually tests. Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
📝 WalkthroughWalkthroughA single test function in the LLM config test suite is renamed and updated to explicitly target the torch-simple compile backend. The test name and backend parameter are synchronized to clarify that piecewise disabling assertions apply to the torch-simple backend scenario in speculative FlashInfer configurations. ChangesSpeculative FlashInfer torch-simple piecewise-disable test update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #53727 [ run ] triggered by Bot. Commit: |
|
PR_Github #53727 [ run ] completed with state |
|
Addressed by #15293 |
@coderabbitai summary
Description
test_speculative_flashinfer_fallback_disables_piecewisewas failing with a hardpydantic.ValidationErrorbecause it was written against the old auto-correction behavior (silent fallback totorch-simple), but thereject_cudagraph_for_speculative_flashinfervalidator now explicitly rejects the speculative + FlashInfer + CUDA-graph-backend combination and requires the user to setcompile_backend='torch-simple'explicitly.Fix: pass
compile_backend="torch-simple"in the test and rename it totest_speculative_flashinfer_torch_simple_disables_piecewiseto accurately describe what it tests. The test still covers a distinct scenario (speculative + flashinfer + torch-simple →piecewise_enabledisFalse) not exercised by the existingtest_accepts_flashinfer_torch_simpleortest_non_piecewise_compile_backend_disables_default_piecewise.Test Coverage
tests/unittest/auto_deploy/singlegpu/shim/test_llm_config.py::test_speculative_flashinfer_torch_simple_disables_piecewise— the renamed/fixed test itselfPR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.