Skip to content

[https://nvbugs/6309375][test] AutoDeploy: Remove stale fallback test - #15316

Merged
govind-ramnarayan merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:gramnarayan/nvbug-6309375
Jun 12, 2026
Merged

[https://nvbugs/6309375][test] AutoDeploy: Remove stale fallback test#15316
govind-ramnarayan merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:gramnarayan/nvbug-6309375

Conversation

@govind-ramnarayan

@govind-ramnarayan govind-ramnarayan commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

FlashInfer attention with speculative decoding and CUDA graph backends is now rejected by AutoDeploy LlmArgs validation. The deleted test asserted the older fallback behavior, which contradicts the current contract and is already covered by TestSpeculativeConfigValidation::test_rejects_flashinfer_cuda_graph_backend for torch-cudagraph and torch-opt.

Drop the matching waive because no skipped test remains for this NVBug.

Summary by CodeRabbit

  • Tests
    • Removed a previously skipped test case and its corresponding waiver entry.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

FlashInfer attention with speculative decoding and CUDA graph backends is now rejected by AutoDeploy LlmArgs validation. The deleted test asserted the older fallback behavior, which contradicts the current contract and is already covered by TestSpeculativeConfigValidation::test_rejects_flashinfer_cuda_graph_backend for torch-cudagraph and torch-opt.

Drop the matching waive because no skipped test remains for this NVBug.

Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Removes the test_speculative_flashinfer_fallback_disables_piecewise test unit test and its corresponding waiver entry. The test validated that speculative decoding with flashinfer backend forced torch-simple compilation and disabled piecewise transforms.

Changes

Test and Waiver Removal

Layer / File(s) Summary
Remove waived test and cleanup
tests/unittest/auto_deploy/singlegpu/shim/test_llm_config.py, tests/integration/test_lists/waives.txt
Deleted the test_speculative_flashinfer_fallback_disables_piecewise test that verified compilation backend enforcement with flashinfer attention, and removed its skip waiver entry from the waiver list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • nvchenghaoz
  • dpitman-nvda
  • tburt-nv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive PR description clearly explains the changes, rationale, and references the NVBug. However, the actual sections (Description and Test Coverage) within the template are not filled out with details. Fill in the 'Description' section with the explanation provided above the template, and add 'Test Coverage' section detailing how TestSpeculativeConfigValidation::test_rejects_flashinfer_cuda_graph_backend covers the removed test.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: removing a stale fallback test from AutoDeploy, with the NVBug reference providing context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@govind-ramnarayan

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@govind-ramnarayan govind-ramnarayan changed the title [https://nvbugs/6309375][test] Remove stale AutoDeploy fallback test [https://nvbugs/6309375][test] AutoDeploy: Remove stale fallback test Jun 12, 2026
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53937 [ run ] triggered by Bot. Commit: adf65d6 Link to invocation

@govind-ramnarayan
govind-ramnarayan enabled auto-merge (squash) June 12, 2026 18:32
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53937 [ run ] completed with state SUCCESS. Commit: adf65d6
/LLM/main/L0_MergeRequest_PR pipeline #43028 completed with status: 'SUCCESS'

CI Report

Link to invocation

@govind-ramnarayan
govind-ramnarayan merged commit 646464b into NVIDIA:main Jun 12, 2026
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants