[https://nvbugs/6309375][test] AutoDeploy: Remove stale fallback test - #15316
Merged
govind-ramnarayan merged 1 commit intoJun 12, 2026
Merged
Conversation
FlashInfer attention with speculative decoding and CUDA graph backends is now rejected by AutoDeploy LlmArgs validation. The deleted test asserted the older fallback behavior, which contradicts the current contract and is already covered by TestSpeculativeConfigValidation::test_rejects_flashinfer_cuda_graph_backend for torch-cudagraph and torch-opt. Drop the matching waive because no skipped test remains for this NVBug. Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
nvchenghaoz
approved these changes
Jun 12, 2026
Contributor
📝 WalkthroughWalkthroughRemoves the ChangesTest and Waiver Removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #53937 [ run ] triggered by Bot. Commit: |
govind-ramnarayan
enabled auto-merge (squash)
June 12, 2026 18:32
Collaborator
|
PR_Github #53937 [ run ] completed with state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlashInfer attention with speculative decoding and CUDA graph backends is now rejected by AutoDeploy LlmArgs validation. The deleted test asserted the older fallback behavior, which contradicts the current contract and is already covered by TestSpeculativeConfigValidation::test_rejects_flashinfer_cuda_graph_backend for torch-cudagraph and torch-opt.
Drop the matching waive because no skipped test remains for this NVBug.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.