Skip to content

[None][chore] Enable one test case after accuracy fix - #15405

Closed
HuiGao-NV wants to merge 0 commit into
NVIDIA:mainfrom
HuiGao-NV:enable_test
Closed

[None][chore] Enable one test case after accuracy fix#15405
HuiGao-NV wants to merge 0 commit into
NVIDIA:mainfrom
HuiGao-NV:enable_test

Conversation

@HuiGao-NV

@HuiGao-NV HuiGao-NV commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Removed a waived test entry to maintain test infrastructure.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

One waived integration test entry, accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_nvfp4_multi_gpus[throughput_pp4_mtp] (tracked via nvbugs/6018046), is removed from tests/integration/test_lists/waives.txt, shifting subsequent entries up by one line.

Changes

Waive List Cleanup

Layer / File(s) Summary
Remove throughput_pp4_mtp waive entry
tests/integration/test_lists/waives.txt
Deletes the waive line for TestDeepSeekR1::test_nvfp4_multi_gpus[throughput_pp4_mtp]; the throughput_tp4 entry now follows directly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • SimengLiu-nv
  • zhhuang-nv
  • yuxianq
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely incomplete with all required sections left blank (no title, description, test coverage, or checklist completion). Fill in all required sections: add a proper PR title following the template format, explain the rationale for removing the waived test, list relevant test coverage, and complete the PR checklist as appropriate.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: enabling a previously waived test case following an accuracy fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@HuiGao-NV

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list="DGX_B300-4_GPUs-PyTorch-Post-Merge-2" --disable-fail-fast

@HuiGao-NV

Copy link
Copy Markdown
Collaborator Author

reopen it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant