[https://nvbugs/6337235][test] Fix MX/GMS model loader fixtures - #15471
Conversation
|
/bot run --disable-fail-fast |
|
PR_Github #54892 [ run ] triggered by Bot. Commit: |
|
PR_Github #54892 [ run ] completed with state
|
eba3038 to
1b115c0
Compare
|
/bot run |
|
PR_Github #54992 [ run ] triggered by Bot. Commit: |
|
PR_Github #54992 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #55009 [ run ] triggered by Bot. Commit: |
|
PR_Github #55009 [ run ] completed with state
|
Stub SourceIdentity construction in the MX/GMS ModelLoader branch tests so the tests keep focusing on branch behavior while dedicated source-identity tests cover fingerprint compatibility. NVBUG 6337235 Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
1b115c0 to
5ec5c41
Compare
|
/bot reuse-pipeline |
|
PR_Github #55063 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #55063 [ reuse-pipeline ] completed with state |
|
/bot run |
|
PR_Github #55068 [ run ] triggered by Bot. Commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo test files for Changessource_identity plumbing in ModelLoader tests
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #55068 [ run ] completed with state |
…IA#15471) Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> Signed-off-by: GitLab CI Bot <gitlab-ci@nvidia.com>
…IA#15471) Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> Signed-off-by: GitLab CI Bot <gitlab-ci@nvidia.com>
…IA#15471) Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> Signed-off-by: GitLab CI Bot <gitlab-ci@nvidia.com>
…IA#15471) Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Description
Fix stale MX/GMS
ModelLoaderunit-test fixtures exposed by the expanded L0 unit-test coverage.ModelLoader.load()now builds aSourceIdentityfor GMS and MX paths. These branch-focused tests stub_load_and_validate_config()with a lightweightSimpleNamespace, so the real fingerprint builder can fail before the tests reach the GMS/MX behavior they are meant to cover. This PR stubsSourceIdentity.from_model_config()in those tests with a fixed realSourceIdentity, and makes the GMS RO backend return the same identity so the strict RO gate still executes successfully.Reference: https://nvbugs/6337235
Test Coverage
PYTHONPYCACHEPREFIX=/private/tmp/trtllm_pycache python3 -m py_compile tests/unittest/_torch/pyexecutor/test_model_loader_gms.py tests/unittest/_torch/pyexecutor/test_model_loader_mx.pygit diff --checkwaive list checkandvalidate-test-listslocally because they crash under this machine's Python 3.9 while parsing Python 3.10 union annotations inscripts/check_test_list.py.Note: focused
pytestwas not runnable in this local environment becausepytestis not installed for the system Python.Summary by CodeRabbit
source_identityparameter is correctly passed and handled throughout the loading pipeline.