[None][fix] Allow fail-early when reuse block and legacy mamba cache - #15540
[None][fix] Allow fail-early when reuse block and legacy mamba cache #15540Wanli-Jiang wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn ChangesBlock reuse guard for legacy hybrid cache manager
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Wanli Jiang <35160485+Wanli-Jiang@users.noreply.github.com>
35a1a7d to
20458ff
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #55222 [ run ] triggered by Bot. Commit: |
| "Block reuse does not work with MTP for hybrid linear models " | ||
| "when using the legacy MambaCacheManager (TRTLLM_USE_CPP_MAMBA=1)" | ||
| ) | ||
| and kv_cache_config.enable_block_reuse \ |
|
PR_Github #55222 [ run ] completed with state
|
|
the change will be merged into #16597 |
| "KVCacheManagerV2 is not supported with %s. " | ||
| "Falling back to KVCacheManager.", incompat_str) | ||
| cls = KVCacheManager | ||
| # The V1-route hybrid mamba managers (disagg, TRTLLM_USE_CPP_MAMBA, |
There was a problem hiding this comment.
actually we can drop this part since no longer used.
Summary by CodeRabbit
Release Notes
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.