[https://nvbugs/6336682][fix] When spec_config is not None, set piecewise_named_args_fn to a lambda… - #15560
[https://nvbugs/6336682][fix] When spec_config is not None, set piecewise_named_args_fn to a lambda…#15560tensorrt-cicd wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughIn ChangesSpeculative decoding compile-model fix and waiver cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
0fb399c to
9534189
Compare
…se CG capture for spec dec The piecewise CUDA-graph capture path's piecewise_named_args_fn returned only cm.named_args, omitting cache_seq_interface. When the EagleWrapper top-level model is invoked with no cache_seq_interface, it dispatches to the prefill-only fallback which calls the FX-graph target_model with just inputs_embeds/position_ids; the post-transform target GraphModule expects the full set of cached SSM/conv state placeholders, raising TypeError: forward() missing 458 required positional arguments. Mirror _get_args_kwargs (which already handles the spec_config branch) so piecewise capture invokes the wrapper through the same KV-cache dispatch the runtime uses (ad_executor.py:1011). Also remove the now-redundant nvbugs/6336682 waiver. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
9534189 to
813bcd1
Compare
|
/bot kill |
|
We disabled piecewise cuda graphs for spec dec for now, so the test was already unwaived. team doesn't have bandwidth to investiagte if this is the suficient fix, so just closing. |
|
PR_Github #56128 [ ] completed with state |
Summary
Test plan
Links
Summary by CodeRabbit
Refactor
Tests