[https://nvbugs/6316981][test] unwaive AutoDeploy SuperV3 MTP tests - #15563
[https://nvbugs/6316981][test] unwaive AutoDeploy SuperV3 MTP tests#15563govind-ramnarayan wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughUpdates ChangesIntegration Test Waiver Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Ran fp8 test locally on a B200 to confirm: |
613045d to
414a3d9
Compare
|
/bot run --stage-list "DGX_H100-4_GPUs-AutoDeploy-1" |
|
PR_Github #55363 [ run ] triggered by Bot. Commit: |
|
PR_Github #55363 [ run ] completed with state
|
|
/bot run |
…lay; unwaive MTP cudagraph tests The SuperV3 MTP cudagraph tests were waived under nvbug 6316981. Root cause: the SSM replay kernel (_persistent_main_kernel in replay_selective_state_update.py), enabled via insert_cached_ssm_attention.ssm_replay=true, hits an illegal memory access during CUDA-graph capture for bf16 and nvfp4 on Blackwell. fp8 is unaffected. Disable ssm_replay in super_v3_mtp.yaml so MTP runs the monolithic cudagraph path with the overlap scheduler on for all dtypes (cudagraph stays enabled; only the Mamba state fast-forward optimization is dropped). A comment documents how to re-enable it once the replay kernel is fixed. Verified on 4xB200: fp8 passes (GSM8K 92.76, accept 52.78%); bf16 builds, captures, and generates correctly with ssm_replay=false (accept 65.91%). Unwaive the GB200/GB300 SuperV3 MTP entries (nvbug 6316981). Also unwaive the DGX_H100 entry (nvbug 6336682), which runs pre-merge, to get CI signal on whether this change resolves it as well. Signed-off-by: gramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
414a3d9 to
0841808
Compare
|
/bot run |
|
PR_Github #55549 [ run ] triggered by Bot. Commit: |
|
PR_Github #55549 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
Closed; better solution that fixes SSM replay for AutoDeploy is in #15622 |
The failure tracked by nvbug 6316981 was caused by piecewise CUDA graph being applied to SuperV3 + MTP, which MTP does not support.
This is now disabled via piecewise_enabled: false in super_v3_mtp.yaml, so MTP runs the monolithic cudagraph path with the overlap scheduler on. See: #15325
Verified TestNemotronSuperV3::test_mtp[fp8_ws4_80gb-trtllm] on B200: GSM8K 92.76 (ref 92.10), spec-dec acceptance 52.78% (>0.40 threshold). Unwaive the GB200 and GB300 entries that share this root cause.
There is no 4xB200 PostMerge entry for AutoDeploy currently enabled, so we cannot test this with PostMerge. We tested manually on 4xB200. The bf16 and nvfp4 tests still failed during cudagraph capture, but are fixed by disabling SSM replay. See: #15565
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.