[TRTLLMINF-152][infra] Waive tests that have too many logs in system-out - #15749
Conversation
|
/bot run --disable-fail-fast --post-merge |
|
/bot run --disable-fail-fast --post-merge |
📝 WalkthroughWalkthroughFour SKIP waiver entries are added to ChangesWaiver List Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 173-176: The softmax-attention waiver is still applied globally
for one Qwen3_30B_A3B_Instruct_2507 case, even though the newer entries are
DGX_B200-scoped. Update the waiver entries in test_lists/waives.txt so the
target_sparsity_0.9-fp8kv=False skip is either removed or restricted to DGX_B200
like the other
`TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus` entries,
keeping the waiver scope consistent with the intended hardware-specific skip.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f7211f21-dedf-424f-aeff-256348a1bc0f
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #56506 [ run ] triggered by Bot. Commit: |
|
PR_Github #56506 [ run ] completed with state |
|
/bot run --stage-list "*" --disable-fail-fast |
|
PR_Github #56796 [ run ] triggered by Bot. Commit: |
|
PR_Github #56796 [ run ] completed with state
|
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
|
/bot skip --comment "Waive tests" |
|
PR_Github #57094 [ skip ] triggered by Bot. Commit: |
|
PR_Github #57094 [ skip ] completed with state |
…out (NVIDIA#15749) Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com> Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
…out (NVIDIA#15749) Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com> Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.