[NVBUG-6280721][fix] Unwaive DeepSeek-V3.2 FP4 MTP perf-sanity test - #15783
Conversation
📝 WalkthroughWalkthroughRemoves 5 waiver entries from ChangesPerf Sanity Waiver Removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
/bot --help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --disable-fail-fast |
|
PR_Github #56804 [ run ] triggered by Bot. Commit: |
|
PR_Github #56804 [ run ] completed with state |
|
/bot run --post-merge --disable-fail-fast --stage-list "*PerfSanity*" |
|
PR_Github #57060 [ run ] triggered by Bot. Commit: |
|
/bot run --disable-fail-fast |
2 similar comments
|
/bot run --disable-fail-fast |
|
/bot run --disable-fail-fast |
|
PR_Github #57123 [ run ] triggered by Bot. Commit: |
|
PR_Github #57060 [ run ] completed with state |
Signed-off-by: Xin Guan <294044352+xguannv@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #57169 [ run ] triggered by Bot. Commit: |
|
PR_Github #57123 [ run ] completed with state |
|
PR_Github #57169 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
1 similar comment
|
/bot run --disable-fail-fast |
|
PR_Github #57315 [ run ] triggered by Bot. Commit: |
|
PR_Github #57315 [ run ] completed with state |
…VIDIA#15783) Signed-off-by: Xin Guan <294044352+xguannv@users.noreply.github.com>
…s fixed by #14891
These 5 perf_sanity test_e2e cases were waived for nvbugs/6280721 (post-merge 2765/2769 on 06/08-06/09), a flaky CUDA illegal memory access hit during the generation CUDA-graph capture of DeepSeek-V3.2-Exp FP4 with MTP draft.
Root cause: the DSA indexer DSL atom-split path was taken for MTP-Eagle draft (i>=1) calls where next_n collapses to 1, while the cached (dsl_expand_factor, dsl_atom) and the pre-built expanded buffers still describe the verify-time next_n. The mismatch drives the paged-MQA-logits kernel with inflated kv-lens / block-table, producing out-of-range top-k indices that convertReqIndexToGlobal (no upper-bound check) maps to an unmapped KV-pool row. PR #14891 (5741389) guards the split on
next_n == dsl_expand_factor * dsl_atom, landing 06/10 -- after the waive was added, so the waive was never re-evaluated.Local validation on clean main (no other change): B200 aggr configs v32_fp4_dep8_mtp1_8k1k and v32_fp4_tep8_mtp3_8k1k pass repeatedly (mtp3 4/4 in CI-faithful pytest runs). The remaining GB200 / disagg configs share the same config-agnostic root cause and fix; relying on CI to validate them.
Summary by CodeRabbit
Description
These waived perf sanity tests are related to flaky illegal memory access during CUDA-graph generation. The root cause in one line: when drafter is decoding, it shares the same config with verifier and thus adopting the wrong path where the verifier should go. This path assumes a longer sequence length than the true sequence length and led to accessing not existing kv cache ids. This problem is fixed by NVBUG-6241842's fix.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.