Skip to content

[https://nvbugs/6410963][chore] Waive a failed test in Pre-merge - #15904

Merged
shuyixiong merged 1 commit into
NVIDIA:mainfrom
shuyixiong:user/shuyix/waive_test
Jul 3, 2026
Merged

[https://nvbugs/6410963][chore] Waive a failed test in Pre-merge#15904
shuyixiong merged 1 commit into
NVIDIA:mainfrom
shuyixiong:user/shuyix/waive_test

Conversation

@shuyixiong

@shuyixiong shuyixiong commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Added a new skip/waive entry for one integration test case tied to a known issue, reducing noise from a failing scenario.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 64bb96d8-2eb4-438c-ac6d-06646c57883a

📥 Commits

Reviewing files that changed from the base of the PR and between 8888dc3 and 0a1e617.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single new SKIP waiver line was added to tests/integration/test_lists/waives.txt for the test test_single_node_transfer in test_cache_transceiver_harness.py, referencing nvbug 6410963.

Changes

Test Waiver Update

Layer / File(s) Summary
Add waiver entry
tests/integration/test_lists/waives.txt
Added a SKIP entry for test_single_node_transfer in test_cache_transceiver_harness.py, referencing nvbugs 6410963.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: dpitman-nvda

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is just the template with no filled-in issue, solution, or test coverage details. Add a short Description of the failure and fix, plus Test Coverage explaining what validates the waive entry.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required ticket/type format and accurately describes waiving a failed pre-merge test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@shuyixiong

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waive a test"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57356 [ skip ] triggered by Bot. Commit: 0a1e617 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57356 [ skip ] completed with state SUCCESS. Commit: 0a1e617
Skipping testing for commit 0a1e617

Link to invocation

@shuyixiong
shuyixiong enabled auto-merge (squash) July 3, 2026 05:14
@shuyixiong
shuyixiong merged commit 7f2804e into NVIDIA:main Jul 3, 2026
14 of 15 checks passed

@Superjomn Superjomn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants