Skip to content

[https://nvbugs/6412133][fix] Only populate self.all_weights[self.device_id] at construction; lazily… #15921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trtllm-agent wants to merge 1 commit into from
Closed

[https://nvbugs/6412133][fix] Only populate self.all_weights[self.device_id] at construction; lazily… #15921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/unittest/_torch/ray_orchestrator/multi_gpu/test_llm_update_weights_multi_gpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,10 +330,12 @@ def _quantize_and_replicate_weights(self):

assert not fusion_buffer, f"Incomplete fusion groups: {list(fusion_buffer.keys())}"

# Only populate the owning device. Extra replicas are created on
# demand by ``get_weight_ipc_handles_serialized`` so that GPUs not
# actually asked for via IPC (e.g. cuda:2/3 on a 4-GPU CI runner
# when a TP=2 test only requests device_ids=[0, 1]) don't hold
# onto NVFP4 quantized tensors that persist across parametrize IDs.
self.all_weights[self.device_id] = model_weights
for i in range(torch.cuda.device_count()):
if i != self.device_id:
self.all_weights[i] = [(n, p.to(f"cuda:{i}")) for n, p in model_weights]

with torch.no_grad():
param_dict = dict(self.model.named_parameters())
Expand Down Expand Up @@ -435,6 +437,10 @@ def get_weight_ipc_handles_serialized(
device_list = list(range(torch.cuda.device_count())) if device_ids is None else device_ids

for device in device_list:
if device not in self.all_weights:
src = self.all_weights[self.device_id]
self.all_weights[device] = [(n, p.to(f"cuda:{device}")) for n, p in src]

all_handles = []
for item in self.all_weights[device]:
name, p = item
Expand Down
Loading