Skip to content

[None][docs] Default GitHub CLI config directory non-interactively - #15978

Merged
bobboli merged 1 commit into
NVIDIA:mainfrom
bobboli:codex/default-gh-config-dir
Jul 9, 2026
Merged

[None][docs] Default GitHub CLI config directory non-interactively#15978
bobboli merged 1 commit into
NVIDIA:mainfrom
bobboli:codex/default-gh-config-dir

Conversation

@bobboli

@bobboli bobboli commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Default gh usage to $HOME/.config/gh when GH_CONFIG_DIR is not explicitly set.
  • Ask for a custom config directory only after authentication or host/account failure.

Testing

  • git diff --check
  • pre-commit hooks via git commit -s

Summary by CodeRabbit

  • Documentation
    • Clarified GitHub CLI setup guidance to use a default configuration directory when none is set.
    • Removed the need for an extra confirmation step during CLI authentication setup.
    • Added guidance for reporting authentication issues when the wrong GitHub account or host is detected.

Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
@bobboli
bobboli force-pushed the codex/default-gh-config-dir branch from a1cce74 to 3354639 Compare July 6, 2026 10:19
@bobboli
bobboli marked this pull request as ready for review July 6, 2026 10:22
@bobboli
bobboli requested a review from a team as a code owner July 6, 2026 10:22
@bobboli
bobboli requested review from arysef and nv-guomingz July 6, 2026 10:22
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7d742d60-a616-4238-afd5-0c1db2c9b2e0

📥 Commits

Reviewing files that changed from the base of the PR and between 398e3e7 and 3354639.

📒 Files selected for processing (1)
  • AGENTS.md

📝 Walkthrough

Walkthrough

Updates AGENTS.md so that GitHub CLI authentication guidance defaults GH_CONFIG_DIR to ~/.config/gh when unset, removing the prior interactive confirmation step, while retaining the instruction to prefix gh commands with the resolved directory.

Changes

Documentation update

Layer / File(s) Summary
GH_CONFIG_DIR default behavior
AGENTS.md
Guidance changed to default GH_CONFIG_DIR to ~/.config/gh without confirmation, retains prefixing rule for gh commands, and adds reporting of auth/host/account failures.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related PRs: None specified.

Suggested labels: documentation

Suggested reviewers: None specified.

🐰 A whisper of change in the docs so plain,
No more asking twice, no need to explain,
GH_CONFIG_DIR now finds its cozy home,
In ~/.config/gh, no more to roam.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the PR's main change and follows the required ticket/type format.
Description check ✅ Passed The description includes the required summary and testing details, though the PR Checklist section is missing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bobboli

bobboli commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57776 [ run ] triggered by Bot. Commit: 3354639 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57776 [ run ] completed with state SUCCESS. Commit: 3354639
/LLM/main/L0_MergeRequest_PR pipeline #46476 completed with status: 'SUCCESS'

CI Report

Link to invocation

Comment thread AGENTS.md
@bobboli
bobboli enabled auto-merge (squash) July 8, 2026 02:22
@bobboli
bobboli merged commit 42d047e into NVIDIA:main Jul 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants