[https://nvbugs/6418018][fix] Add two parametrized test functions test_medusa[medusa] and… - #15996
[https://nvbugs/6418018][fix] Add two parametrized test functions test_medusa[medusa] and…#15996trtllm-agent wants to merge 1 commit into
test_medusa[medusa] and…#15996Conversation
… regression guards The examples/medusa/ and examples/eagle/ directories were deleted by PR NVIDIA#15763 (commit e5a05b2), but the triton_server test harness (build_model.sh, test.sh, test_triton.py) still referenced them. Running test_medusa[medusa] fails with 'pushd: examples/medusa: No such file or directory'. - Delete the dead medusa/eagle branches in build_model.sh and test.sh, plus the four unused example-root/vicuna-model-root fixtures in conftest.py. - Replace the old test_medusa/test_eagle bodies with regression guards that assert the removed example directories are absent. This preserves the pytest node ids test_medusa[medusa] and test_eagle[eagle] (so schedulers pinning those names do not fail with rc=4) while documenting PR NVIDIA#15763's cleanup and preventing silent reintroduction without matching harness support. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThis PR removes support for medusa and eagle model testing in the Triton server test infrastructure. It deletes build branches, pytest fixtures, and test.sh sections for these models, and rewrites test_medusa/test_eagle to assert that legacy example directories no longer exist. ChangesMedusa/Eagle Triton test removal
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
will remove the test since legacy TRT backend along with triton-server is removed |
Summary
examples/medusa/andexamples/eagle/were deleted by PR [TRTLLM-13781][chore] Remove legacy TensorRT examples #15763 but the triton_server test harness still referenced them; simply deleting the pytest tests broke the verify harness (which pins the node idtest_medusa[medusa]) with rc=4 "not collected".test_medusa[medusa]andtest_eagle[eagle]that only takellm_root/test_nameand assertos.path.exists(examples/{medusa,eagle}) is False; leave build_model.sh, test.sh, conftest.py cleanups from attempt 0 intact.Test plan
Links
Summary by CodeRabbit