Skip to content

[https://nvbugs/6418006][fix] Mirror the test_medusa pattern from commit b08ce26ac1 — replace test_whisper's…#16006

Closed
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6418006
Closed

[https://nvbugs/6418006][fix] Mirror the test_medusa pattern from commit b08ce26ac1 — replace test_whisper's…#16006
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6418006

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Root cause: PR [TRTLLM-13781][chore] Remove legacy TensorRT examples #15763 deleted examples/models/core/whisper/, but build_model.sh's whisper branch still pushd's into it and invokes convert_checkpoint.py, aborting with CalledProcessError under set -e.
  • Fix: Mirror the test_medusa pattern from commit b08ce26 — replace test_whisper's body with an assertion that the removed convert_checkpoint.py has not been reintroduced. Keeps pytest node id resolvable while removing the broken build/test.sh invocation.
  • Automated fix generated by repair-bot

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Summary by CodeRabbit

  • Tests
    • Updated Whisper integration coverage to validate the expected file layout and fail clearly if a removed script reappears.
    • Simplified the test setup by removing unused build and execution steps from this check.

PR NVIDIA#15763 removed examples/models/core/whisper/ as part of the legacy
TensorRT-backend cleanup, but tests/integration/defs/triton_server/build_model.sh
still ran 'pushd examples/models/core/whisper' and invoked convert_checkpoint.py
for the whisper target, causing the Triton post-merge test to fail with
'pushd: examples/models/core/whisper: No such file or directory'.

Replace the body of test_whisper with a lightweight assertion that the
removed convert_checkpoint.py script has not been reintroduced. This keeps
the pytest node id resolvable (the harness runs the test by exact node id)
while removing the broken build/test.sh invocation. Mirrors the pattern
used for test_medusa in nvbugs/6418017. The dead 'whisper' branches in
build_model.sh and test.sh are no longer reachable and can be pruned in
a follow-up cleanup.

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@trtllm-agent
trtllm-agent requested a review from a team as a code owner July 6, 2026 21:35
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 450bed07-1653-4bc7-9bea-c8a080ed1474

📥 Commits

Reviewing files that changed from the base of the PR and between a0c406f and b325280.

📒 Files selected for processing (1)
  • tests/integration/defs/triton_server/test_triton.py

📝 Walkthrough

Walkthrough

The test_whisper function in the Triton server integration tests was rewritten to remove model building and execution logic, replacing it with an assertion verifying that convert_checkpoint.py does not exist under llm_root. The function signature was simplified accordingly.

Changes

Whisper Test Change

Layer / File(s) Summary
Guard assertion replaces build/run logic
tests/integration/defs/triton_server/test_triton.py
test_whisper no longer builds the model or runs test.sh; it now asserts convert_checkpoint.py is absent under llm_root, and the function signature drops model_path and engine_dir parameters.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

A rabbit hops through test files old,
Removes the build, the scripts once bold,
Now checks a path that should be bare,
No convert script waiting there,
A tidy hop, a simpler tale to tell.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses a valid bug tag and fix type and clearly points to the Whisper test replacement.
Description check ✅ Passed The description includes Summary, Test plan, and Links, and it explains the issue and fix clearly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants