[https://nvbugs/6418006][fix] Mirror the test_medusa pattern from commit b08ce26ac1 — replace test_whisper's…#16006
Conversation
PR NVIDIA#15763 removed examples/models/core/whisper/ as part of the legacy TensorRT-backend cleanup, but tests/integration/defs/triton_server/build_model.sh still ran 'pushd examples/models/core/whisper' and invoked convert_checkpoint.py for the whisper target, causing the Triton post-merge test to fail with 'pushd: examples/models/core/whisper: No such file or directory'. Replace the body of test_whisper with a lightweight assertion that the removed convert_checkpoint.py script has not been reintroduced. This keeps the pytest node id resolvable (the harness runs the test by exact node id) while removing the broken build/test.sh invocation. Mirrors the pattern used for test_medusa in nvbugs/6418017. The dead 'whisper' branches in build_model.sh and test.sh are no longer reachable and can be pruned in a follow-up cleanup. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesWhisper Test Change
Estimated code review effort: 1 (Trivial) | ~5 minutes PoemA rabbit hops through test files old, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
set -e.Test plan
Links
Summary by CodeRabbit