Skip to content

[https://nvbugs/6417978][fix] Mirror the medusa/whisper precedent: replace test_gptj's body with an…#16007

Closed
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6417978
Closed

[https://nvbugs/6417978][fix] Mirror the medusa/whisper precedent: replace test_gptj's body with an…#16007
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6417978

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Root cause: PR [TRTLLM-13781][chore] Remove legacy TensorRT examples #15763 removed examples/models/contrib/gptj/, but build_model.sh still runs pushd examples/models/contrib/gptj for the gptj target, so set -e propagates the failure to pytest.
  • Fix: Mirror the medusa/whisper precedent: replace test_gptj's body with an os.path.exists assertion on examples/models/contrib/gptj/ and drop the now-unused model_path/engine_dir fixture params.
  • Automated fix generated by repair-bot

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Summary by CodeRabbit

  • Tests
    • Updated the Triton integration test suite to verify the legacy GPT-J example directory is no longer present.
    • Improved the failure message so any reintroduction of that legacy example is flagged clearly.

PR NVIDIA#15763 removed examples/models/contrib/gptj/ as part of the legacy
TensorRT-backend cleanup, but tests/integration/defs/triton_server/build_model.sh
still ran 'pushd examples/models/contrib/gptj' for the gptj target, causing the
Triton smoke test to fail with 'pushd: examples/models/contrib/gptj: No such
file or directory'.

Replace the body of test_gptj with a lightweight assertion that
examples/models/contrib/gptj/ remains absent under llm_root. This keeps the
pytest node id resolvable (the harness runs the test by exact node id) while
removing the broken build/test.sh invocation. Mirrors the fixes for test_medusa
(b08ce26) and test_whisper (b325280). The dead 'gptj' branches in
build_model.sh and test.sh are no longer reachable and can be pruned in a
follow-up cleanup.

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The test_gptj function in tests/integration/defs/triton_server/test_triton.py was changed from building and running a GPT-J Triton server test to a guard assertion verifying that the legacy GPT-J example directory does not exist, with model_path and engine_dir parameters removed.

Changes

GPT-J Triton Test Update

Layer / File(s) Summary
Replace build/run flow with directory guard
tests/integration/defs/triton_server/test_triton.py
test_gptj no longer calls build_model/run_shell_command; it now asserts that llm_root/examples/models/contrib/gptj does not exist and drops the model_path/engine_dir fixture parameters.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title includes the bug ticket, type, and the main test_gptj change, so it is specific and related to the PR.
Description check ✅ Passed The description covers the root cause, fix, test plan, and bug link, which matches the template well.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/integration/defs/triton_server/test_triton.py (1)

135-135: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Drop the unused tritonserver_test_root fixture. test_name is required by the indirect parametrization, but tritonserver_test_root isn’t referenced here and can be removed unless it’s needed for fixture setup.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/defs/triton_server/test_triton.py` at line 135, Remove the
unused tritonserver_test_root fixture from test_gptj in the triton server
integration test, since the function does not reference it and only test_name is
required by the indirect parametrization. Keep the remaining fixtures that are
actually used, and if tritonserver_test_root was only present for setup, move
that setup into the appropriate fixture or autouse fixture instead of the test
signature.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/integration/defs/triton_server/test_triton.py`:
- Line 135: Remove the unused tritonserver_test_root fixture from test_gptj in
the triton server integration test, since the function does not reference it and
only test_name is required by the indirect parametrization. Keep the remaining
fixtures that are actually used, and if tritonserver_test_root was only present
for setup, move that setup into the appropriate fixture or autouse fixture
instead of the test signature.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c37c8685-34d4-492a-961c-f1418831cf15

📥 Commits

Reviewing files that changed from the base of the PR and between a0c406f and e5e1b00.

📒 Files selected for processing (1)
  • tests/integration/defs/triton_server/test_triton.py

@Wanli-Jiang Wanli-Jiang closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants