Skip to content

[None][infra] waive failing tests in Post Merge - #16039

Merged
mzweilz merged 1 commit into
NVIDIA:mainfrom
mzweilz:user/mengzew/waive-6422415-6422432-6422339-6422443
Jul 7, 2026
Merged

[None][infra] waive failing tests in Post Merge#16039
mzweilz merged 1 commit into
NVIDIA:mainfrom
mzweilz:user/mengzew/waive-6422415-6422432-6422339-6422443

Conversation

@mzweilz

@mzweilz mzweilz commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated test waiver entries for a few known failing cases so the test suite reflects current expectations and runs more smoothly.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Four new SKIP waiver entries are added to tests/integration/test_lists/waives.txt, covering a DeepSeekV3Lite nvfp4 4-gpu accuracy test, an A30 cpp batch_manager unit test, a GB300 unittest for thop/parallel, and a perf sanity e2e aggr_upload test, each referencing an NVBUG ID.

Changes

Waiver list updates

Layer / File(s) Summary
Add SKIP waiver entries
tests/integration/test_lists/waives.txt
Adds four SKIP entries for a DeepSeekV3Lite nvfp4 4-gpu accuracy test, an A30 batch_manager cpp unit test, a GB300 thop/parallel unittest, and a perf sanity aggr_upload e2e test, each tagged with an NVBUG reference.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: xinhe-nv, yuxianq

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is just the template and lacks filled-in issue context, solution details, and test coverage. Fill in the Description and Test Coverage sections with the problem, the waiver changes, and any validation performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the change and follows the repo's [None][infra] pattern.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
@mzweilz
mzweilz force-pushed the user/mengzew/waive-6422415-6422432-6422339-6422443 branch from 87d9748 to 11e1921 Compare July 7, 2026 06:47
@mzweilz

mzweilz commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waive only"

@mzweilz
mzweilz enabled auto-merge (squash) July 7, 2026 06:54
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57962 [ skip ] triggered by Bot. Commit: 11e1921 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57962 [ skip ] completed with state SUCCESS. Commit: 11e1921
Skipping testing for commit 11e1921

Link to invocation

@mzweilz
mzweilz merged commit fe53bc3 into NVIDIA:main Jul 7, 2026
8 checks passed
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants