[https://nvbugs/6422315][fix] Decorate PythonMambaCacheManager.add_dummy_requests with…#16070
Closed
trtllm-agent wants to merge 1 commit into
Closed
[https://nvbugs/6422315][fix] Decorate PythonMambaCacheManager.add_dummy_requests with…#16070trtllm-agent wants to merge 1 commit into
trtllm-agent wants to merge 1 commit into
Conversation
PythonMambaCacheManager.add_dummy_requests writes into self.mamba_cache.prev_num_accepted_tokens / cache_buf_idx on the MTP replay path. Those tensors are inference tensors, so any in-place update must run inside torch.inference_mode(). The sibling helpers _prepare_mamba_cache_blocks and _refresh_dummy_request_mask are already decorated; add_dummy_requests was missed by the replay-checkpoint change, and under attention-DP it is invoked from _pad_attention_dp_dummy_request outside any inference-mode guard, producing 'Inplace update to inference tensor outside InferenceMode is not allowed' on all ranks. Add @torch.inference_mode() to PythonMambaCacheManager.add_dummy_requests and unwaive TestNemotronSuperV3::test_mtp[bf16_ws4_180gb-trtllm]. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR makes two unrelated small changes: it adds a ChangesSmall unrelated fixes
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
Duplicate with 16000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Links
Summary by CodeRabbit
Bug Fixes
Tests