Skip to content

[None][infra] Remove attention op sync test waivers - #16117

Merged
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
yuxianq:chore/remove-pr-16100-waivers
Jul 8, 2026
Merged

[None][infra] Remove attention op sync test waivers#16117
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
yuxianq:chore/remove-pr-16100-waivers

Conversation

@yuxianq

@yuxianq yuxianq commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated the integration test waiver list by removing two no-longer-needed entries.

Description

Remove the two attention synchronization test waivers added by #16100 so these tests resume running in CI:

  • test_attr_kwarg_names_match_source_leaf_attrs_except_allowlisted_aliases
  • test_every_forward_args_field_is_consumed

Test Coverage

Not run (waiver-only cleanup; per request). The test-list validation pre-commit hooks passed.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: dcd5c6fc-1721-4f90-a888-fae26dd10737

📥 Commits

Reviewing files that changed from the base of the PR and between 54cffcd and bd880c7.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Two waiver entries for attention sync tests in unittest/_torch/attention/test_attention_op_sync.py are removed from tests/integration/test_lists/waives.txt, with no replacement entries added.

Changes

Waiver list update

Layer / File(s) Summary
Remove obsolete attention sync waivers
tests/integration/test_lists/waives.txt
Removes two SKIP waiver entries for test_attr_kwarg_names_match_source_leaf_attrs_except_allowlisted_aliases and test_every_forward_args_field_is_consumed in unittest/_torch/attention/test_attention_op_sync.py, with no replacements added.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#16100: Both PRs modify the same two waiver entries for test_attention_op_sync.py in tests/integration/test_lists/waives.txt.
  • NVIDIA/TensorRT-LLM#16093: Both PRs modify tests/integration/test_lists/waives.txt to adjust CI test waiver entries.
  • NVIDIA/TensorRT-LLM#16105: Both PRs modify tests/integration/test_lists/waives.txt to change which test cases are waived.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the PR template and clearly summarizes the waiver-removal change.
Description check ✅ Passed The description includes the required Description, Test Coverage, and PR Checklist sections with clear content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@yuxianq
yuxianq requested a review from nv-guomingz July 8, 2026 09:53
@yuxianq

yuxianq commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58217 [ run ] triggered by Bot. Commit: bd880c7 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58217 [ run ] completed with state FAILURE. Commit: bd880c7
/LLM/main/L0_MergeRequest_PR pipeline #46859 completed with status: 'ABORTED'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@yuxianq

yuxianq commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58220 [ run ] triggered by Bot. Commit: bd880c7 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58220 [ run ] completed with state SUCCESS. Commit: bd880c7
/LLM/main/L0_MergeRequest_PR pipeline #46862 completed with status: 'SUCCESS'

CI Report

Link to invocation

@nv-guomingz
nv-guomingz merged commit 5042300 into NVIDIA:main Jul 8, 2026
11 checks passed
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants